No -Werror on non-debug builds, check 32 bit build in CI#9101
Open
rustyrussell wants to merge 4 commits intoElementsProject:masterfrom
Open
No -Werror on non-debug builds, check 32 bit build in CI#9101rustyrussell wants to merge 4 commits intoElementsProject:masterfrom
rustyrussell wants to merge 4 commits intoElementsProject:masterfrom
Conversation
rustyrussell
force-pushed
the
no-Werror-non-devbuilds
branch
3 times, most recently
from
170fc62 to
43815e7
Compare
Otherwise, we can break people's builds if they upgrade compiler, for example. Yet we still want -Werror for developers, and CI. Changelog-Changed: Build: We no longer use `-Werror` by default, unless --enable-debugbuild is set. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
no-Werror-non-devbuilds
branch
3 times, most recently
from
b3327e0 to
b1b1b47
Compare
This broke the recent docker upload in the release. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
no-Werror-non-devbuilds
branch
from
b1b1b47 to
2397adc
Compare
It would need to run under uv. I noticed it failing while debugging the 32-bit CI build, but it fails everywhere. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
They're misleading otherwise. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This delayed the previous release, as 32 bit didn't build and this was only caught in the docker build phase of release. And future version of gcc add new warnings, which stops build entirely for users, so avoid -Werror for them