[Feature] Add generation_kwargs jinja templating#3684
Open
RawthiL wants to merge 1 commit intoEleutherAI:mainfrom
Open
[Feature] Add generation_kwargs jinja templating#3684RawthiL wants to merge 1 commit intoEleutherAI:mainfrom
generation_kwargs jinja templating#3684RawthiL wants to merge 1 commit intoEleutherAI:mainfrom
Conversation
Contributor
Author
|
I prefer not to lint at this point since the changes made by the linter will be more than the actual changes introduced in this PR. Happy to lint before merging tho... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
generation_kwargsof a task definition are fixed once they are defined, meaning that setting something like:Would define the generation for all samples in the task with the given parameters. However one could be interested in making this variable, specially for things like
tools. This is why we introduce this PR to enable jinja templating of thegeneration_kwargsfields, using the normal syntax.This PR enables the construction of
generation_kwargsthat are modified per sample, like:During generation, the
toolsfield of the request will be filled with the content of the sample'stoolsfield, changing from sample to sample.Changes to the codebase are minimum an enable many other applications besides setting tools dynamically.
This PR along with #3685 are part of an effort to enable tool-usage and function calling evaluation on the
lm-evalsoftware. We have modified the T-Eval dataset and created alm-evalcompatible one: T-Eval PNYX dataset that includes several tasks for measuring function calls. Tasks are working and we wish to share them.