Fix mmlu_pro fewshot answers leaking into user role under chat template#3693
Open
kiwaku wants to merge 1 commit intoEleutherAI:mainfrom
Open
Fix mmlu_pro fewshot answers leaking into user role under chat template#3693kiwaku wants to merge 1 commit intoEleutherAI:mainfrom
kiwaku wants to merge 1 commit intoEleutherAI:mainfrom
Conversation
fewshot_to_text included the full cot_content while fewshot_config.doc_to_target was empty, so fewshot answers were rendered into the user role instead of an assistant turn. Add format_cot_target, point doc_to_target at it, and keep fewshot_to_text limited to the answer stub. Fixes EleutherAI#2780
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2780.
When using
--apply_chat_template, fewshot reasoning was being included in the user turn instead of split across user/assistant roles.Changes:
format_cot_targethelper andfewshot_to_targetpartial inutils.pyfewshot_to_textto exclude the answer content_default_template_yamlto use the new target functionBased on the fix approach proposed by @Moreh-LeeJunhyeok in #2780.