fix: add ray as dependency of lm-eval[vllm]#3701
Open
Anai-Guo wants to merge 1 commit intoEleutherAI:mainfrom
Open
fix: add ray as dependency of lm-eval[vllm]#3701Anai-Guo wants to merge 1 commit intoEleutherAI:mainfrom
Anai-Guo wants to merge 1 commit intoEleutherAI:mainfrom
Conversation
vllm_causallms.py imports ray at line 14, but ray is not listed in the vllm extras. This causes ImportError when using the vllm backend unless ray happens to be installed separately. Fixes EleutherAI#3688
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
lm_eval/models/vllm_causallms.pyimportsrayat line 14, butrayis not listed in thevllmextras inpyproject.toml. This causesImportErrorwhen using the vllm backend unlessrayhappens to be installed separately.Fix
Add
rayto thevllmoptional dependency group inpyproject.toml.Fixes #3688