This repository was archived by the owner on Jun 1, 2026. It is now read-only.
Conversation
fornwall
force-pushed
the
start-snapshot-tests
branch
12 times, most recently
from
November 23, 2023 11:56
e6299fb to
8175b64
Compare
fornwall
force-pushed
the
start-snapshot-tests
branch
from
January 4, 2024 11:03
8175b64 to
ac5e584
Compare
fornwall
force-pushed
the
start-snapshot-tests
branch
from
January 4, 2024 11:16
ac5e584 to
3371226
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7.
Setup skeleton for snapshot tests:
tests/snapshots/in: Contains.wgsl,.glslor.spvasmfiles as input.tests/snapshots/in-spvasm: Contains the.spvfiles generated from the above.wgsl(usingnaga) or.glsl(using glslangValidator`) in files.tests/snapshots/out-spirt: The.spirtfiles we generate from the files in the previous step.tests/snapshots/out-spvasm: The.spvwe generate from the files in the previous step.Running
cargo testgenerates files in thein-spvasm,outandout-spvasmdirectories. The CI check validates that files have not changed, and that the generated.spvfiles assembles and validates. If you are happy with generated changes as part of a PR, the updated snaphots should be included in the PR and be part of the review.Future follow up work:
tests/snapshots/in-spvasmandtests/snapshots/out-spvasmproduce the same output.