Skip to content

Fix division by 0 warning #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apaleyes merged 1 commit into from
Feb 5, 2026
Merged

Fix division by 0 warning #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion emukit/bayesian_optimization/acquisitions/local_penalization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,12 @@ def _distance_calculation(x_1, x_2):

def _distance_with_gradient(x_1, x_2):
distances = _distance_calculation(x_1, x_2)
inv_distance = np.where(distances != 0.0, 1 / distances, 0)
# This line is quite tricky and needs explanation
# First, "~" negates boolean numpy array
# Second, divide is only doing division in indexes
# where provided condition is true
# otherwise corresponding member of "out" arg is returned
inv_distance = np.divide(1, distances, out=np.zeros_like(distances), where=~np.isclose(distances, 0))
dx = x_1[:, None, :] - x_2[None, :, :]
d_dist_dx = 2 * dx * inv_distance[:, :, None]
return distances, d_dist_dx