create parity between //snow and //thaw#2940
Merged
octylFractal merged 4 commits intoEngineHub:masterfrom Apr 20, 2026
Merged
Conversation
octylFractal
requested changes
Apr 8, 2026
Member
octylFractal
left a comment
octylFractal
left a comment
There was a problem hiding this comment.
Is it possible to also make thaw use block positions from a CylinderRegion instead? I'm unsure if it works properly, but I would rather use the same source of truth if we can.
Contributor
Author
|
Done as suggested |
octylFractal
requested changes
Apr 20, 2026
Member
octylFractal
left a comment
octylFractal
left a comment
There was a problem hiding this comment.
BTW, if you're able to, re-requesting a review helps me sort PRs better.
octylFractal
approved these changes
Apr 20, 2026
Member
|
Since this is feature work, I'm going to put it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makes //thaw and //snow cover the same area