One Native Code to Rule Them All#2951
Open
octylFractal wants to merge 4 commits intoversion/7.4.xfrom
Open
Conversation
me4502
reviewed
Apr 13, 2026
| return this.config; | ||
| } | ||
|
|
||
| protected void setupRegistries(MinecraftServer server) { |
Member
There was a problem hiding this comment.
I am semi concerned about just how tightly we're tying it to how NF/Fabric currently work. Eg, when it comes to registries we've in the past expressed interest in moving these to platform registry events etc.
I'm just a little concerned we're going to end up in spots where it's significant work to override something on a per-platform basis because of how closely we're tying it all to current behaviour
Member
Author
There was a problem hiding this comment.
This is all internal so we can refactor it however we want later. There is nothing preventing us from changing all of this code.
85fdb89 to
8ea3716
Compare
This also makes Adapter an abstract class implemented by the platforms, which expose their adapter back to coremc and also to other mods.
8ea3716 to
31cf21e
Compare
7245c39 to
a143c97
Compare
me4502
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One native code to rule them all,
one native code to find them,
One native code to bring them all
and in the darkness bind them.
Merges most of Fabric and NeoForge into core-mc. This new project is just Fabric without the Fabric Loader or API, giving us a clean Minecraft dependency to build off of.
In the future, parts of this may be applicable to Paper as well. However, due to the nature of their patches, it's not as easy to assume that it builds cleanly. It may be necessary to instead copy sources to Paper to be compiled against it directly, to ensure there's no missing signatures or other incompatibilities.
See
worldedit-core-mc/README.mdfor a better way to inspect the diff here.