Repo cleanup: drop Dependabot, pin setup-go, add golangci config - #401
Merged
Conversation
This repo already uses Renovate (renovate.json), and Renovate's config:recommended preset covers both gomod and github-actions — the same ecosystems Dependabot was configured for. Running both bots produces duplicate update PRs against the same dependencies. Dropping Dependabot leaves Renovate as the single source of truth and aligns this repo with awesome-software-engineering-games, which uses only Renovate.
Other workflows in this repo (podcast-data.yml, render-readme.yml) already pin setup-go to v6.4.0, while testing.yml used the floating major @v6. Aligning all workflows on the same explicit version makes the CI environment fully reproducible and lets Renovate manage the upgrade in one place.
Previously golangci-lint ran with its built-in defaults. Adding an explicit config makes the active linter set visible in the repo and keeps the lint posture aligned with awesome-software-engineering-games. The enabled linters (errcheck, govet, ineffassign, unused, misspell) are the standard set. staticcheck is disabled here because it is run separately via 'make staticcheck' against the standalone binary, so having it in golangci-lint would double-report. The errcheck exclusion for (*net/http.Response).Body.Close avoids noise on a common Go idiom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small, isolated cleanups identified during a side-by-side comparison with
awesome-software-engineering-games:.github/dependabot.yml. Renovate is already configured here and itsconfig:recommendedpreset covers the samegomodandgithub-actionsecosystems. Running both bots produces duplicate update PRs; Renovate is now the single source of truth.actions/setup-gotov6.4.0intesting.yml. The other workflows (podcast-data.yml,render-readme.yml) already pin this version; onlytesting.ymlused the floating major@v6. All workflows now use the same explicit version.app/.golangci.yml. Previously golangci-lint ran with built-in defaults; the explicit config makes the active linter set visible and aligns this repo's lint posture withawesome-software-engineering-games. The enabled set is the standarderrcheck,govet,ineffassign,unused,misspell.staticcheckis intentionally disabled here because it's run separately viamake staticcheck.No behavior changes apart from the new lint config. If golangci-lint flags pre-existing code, follow-up commits can fix those issues without touching this PR's intent.
Test plan
Testingworkflow runs green (golangci-lint with the new config in particular)YAML lintworkflow runs greenRender READMEworkflow runs green🤖 Generated with Claude Code