Skip to content

fix(node): demote proposal fetch log to debug on dropped response #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imabdulbasit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(node): demote proposal fetch log to debug on dropped response #4691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion crates/espresso/node/src/proposal_fetcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use committable::Commitment;
use derivative::Derivative;
use espresso_types::{PubKey, ValidatedState, parse_duration, v0::traits::SequencerPersistence};
use futures::stream::StreamExt;
use hotshot_new_protocol::client::QueryError;
use hotshot_types::{
data::{Leaf2, QuorumProposalWrapper, ViewNumber},
event::{Event, EventType},
Expand Down Expand Up @@ -233,7 +234,16 @@ where
.instrument(span)
.await;
if let Err(err) = res {
tracing::warn!(?view, err = %format!("{err:#}"), "failed to fetch proposal");
// A dropped response usually means the coordinator GCed the
// pending fetch when the view was decided
if matches!(
err.downcast_ref::<QueryError>(),
Some(QueryError::ResponseDropped)
) {
tracing::debug!(?view, err = %format!("{err:#}"), "failed to fetch proposal");
} else {
tracing::warn!(?view, err = %format!("{err:#}"), "failed to fetch proposal");
}
self.metrics.failed.add(1);

// Avoid busy loop when operations are failing.
Expand Down
Loading