refactor: drop tide-disco from node, orchestrator, lcqs (rm tide 5/5)#4707
refactor: drop tide-disco from node, orchestrator, lcqs (rm tide 5/5)#4707sveitser wants to merge 13 commits into
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
1fafce3 to
7e9a4f7
Compare
66a6119 to
36c2885
Compare
The axum server serves everything; the tide-disco App was built and immediately dropped in every serve mode purely to keep the module definitions compiling. Delete the App construction and the endpoints tree, swap tide-disco re-exported types (StatusCode, Error, ServerError) to their disco-types originals, move get_public_env_vars, and reimplement status metrics() with prometheus::TextEncoder (byte-identical exposition). tide-disco remains only in the hotshot builder/testing crates and the query/events service definitions.
36c2885 to
c172061
Compare
7e9a4f7 to
7c9ac8a
Compare
aide only derives path parameters from named-struct Path<T>
extractors; the v1 handlers all use primitives and tuples, so every
operation showed zero parameters and Swagger's try-it-out could not
fill the URL templates. Declare a required string parameter for every
{name} template segment after finish_api (string because primitive
extractors carry no type metadata; handlers parse).
Also: Swagger UI opens operations with try-it-out enabled; the
test_api example moves to port 5001 (macOS AirPlay holds 5000) and
its startup log lists the v1 doc URLs.
drive_ws_stream only noticed a dead client on the next send, so a socket whose stream was quiet held its max_connections slot and its stream task forever; reconnect churn exhausted the demo's budget of 25 and every plain request got 429, killing the native-demo e2e tests (claim-rewards-loop exits on non-404 and tears the demo down). Poll the client side with select so disconnects release the slot and end the task immediately. Regression test now uses a never-yielding stream.
1 participant
(byte-identical exposition); moves get_public_env_vars
builder-api, events-service, hqs internals; separate effort