refactor: migrate themed common test helper to browser mode#14254
Draft
refactor: migrate themed common test helper to browser mode#14254
themed common test helper to browser mode#14254Conversation
github-actions
bot
added
the
refactor
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors component theming tests by migrating usage of the themed common test helper from the Puppeteer-based *.e2e.ts suite into Vitest Browser Mode *.browser.e2e.tsx tests, aligning them with the browser-mode common test helpers.
Changes:
- Stop exporting
themedfromtests/commonTestsand instead export it fromtests/commonTests/browser. - Remove
describe("theme/themed")blocks from many Puppeteer*.e2e.tstests. - Add equivalent
describe("themed")coverage to the corresponding*.browser.e2e.tsxtests usingmount(...).
Reviewed changes
Copilot reviewed 141 out of 141 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/tests/commonTests/index.ts | Removes themed export from the Puppeteer commonTests barrel. |
| packages/components/src/tests/commonTests/browser/index.ts | Adds themed export to the browser-mode commonTests barrel. |
| packages/components/src/components/tooltip/tooltip.e2e.ts | Removes Puppeteer theming tests for tooltip. |
| packages/components/src/components/tooltip/tooltip.browser.e2e.tsx | Adds browser-mode theming tests for tooltip. |
| packages/components/src/components/time-picker/time-picker.e2e.ts | Removes Puppeteer theming tests for time-picker. |
| packages/components/src/components/time-picker/time-picker.browser.e2e.tsx | Adds browser-mode theming tests for time-picker. |
| packages/components/src/components/tile/tile.browser.e2e.tsx | Adds browser-mode theming tests for tile. |
| packages/components/src/components/text-area/text-area.e2e.ts | Removes Puppeteer theming tests for text-area. |
| packages/components/src/components/text-area/text-area.browser.e2e.tsx | Adds browser-mode theming tests for text-area. |
| packages/components/src/components/tabs/tabs.e2e.ts | Removes Puppeteer theming tests for tabs. |
| packages/components/src/components/tabs/tabs.browser.e2e.tsx | Adds browser-mode theming tests for tabs. |
| packages/components/src/components/tab/tab.e2e.ts | Deletes Puppeteer-only theming test file for tab. |
| packages/components/src/components/tab/tab.browser.e2e.tsx | Adds browser-mode theming tests for tab. |
| packages/components/src/components/tab-title/tab-title.e2e.ts | Removes Puppeteer theming tests for tab-title. |
| packages/components/src/components/tab-title/tab-title.browser.e2e.tsx | Adds browser-mode theming tests for tab-title. |
| packages/components/src/components/tab-nav/tab-nav.e2e.ts | Removes Puppeteer theming tests for tab-nav. |
| packages/components/src/components/tab-nav/tab-nav.browser.e2e.tsx | Adds browser-mode theming tests for tab-nav. |
| packages/components/src/components/switch/switch.e2e.ts | Removes Puppeteer theming tests for switch. |
| packages/components/src/components/switch/switch.browser.e2e.tsx | Adds browser-mode theming tests for switch. |
| packages/components/src/components/swatch/swatch.e2e.ts | Removes Puppeteer theming tests for swatch. |
| packages/components/src/components/swatch/swatch.browser.e2e.tsx | Adds browser-mode theming tests for swatch. |
| packages/components/src/components/stepper/stepper.e2e.ts | Removes Puppeteer theming tests for stepper. |
| packages/components/src/components/stepper/stepper.browser.e2e.tsx | Adds browser-mode theming tests for stepper. |
| packages/components/src/components/stepper-item/stepper-item.browser.e2e.tsx | Adds browser-mode theming tests for stepper-item. |
| packages/components/src/components/slider/slider.e2e.ts | Removes Puppeteer theming tests for slider. |
| packages/components/src/components/slider/slider.browser.e2e.tsx | Adds browser-mode theming tests for slider. |
| packages/components/src/components/shell/shell.e2e.ts | Removes Puppeteer theming tests for shell. |
| packages/components/src/components/shell/shell.browser.e2e.tsx | Adds browser-mode theming tests for shell. |
| packages/components/src/components/shell-panel/shell-panel.e2e.ts | Removes Puppeteer theming tests for shell-panel. |
| packages/components/src/components/shell-panel/shell-panel.browser.e2e.tsx | Adds browser-mode theming tests for shell-panel. |
| packages/components/src/components/sheet/sheet.e2e.ts | Removes Puppeteer theming tests for sheet. |
| packages/components/src/components/sheet/sheet.browser.e2e.tsx | Adds browser-mode theming tests for sheet. |
| packages/components/src/components/select/select.e2e.ts | Removes Puppeteer theming tests for select. |
| packages/components/src/components/select/select.browser.e2e.tsx | Adds browser-mode theming tests for select. |
| packages/components/src/components/segmented-control/segmented-control.e2e.ts | Removes Puppeteer theming tests for segmented-control. |
| packages/components/src/components/segmented-control/segmented-control.browser.e2e.tsx | Adds browser-mode theming tests for segmented-control. |
| packages/components/src/components/segmented-control-item/segmented-control-item.e2e.ts | Removes Puppeteer theming tests for segmented-control-item. |
| packages/components/src/components/segmented-control-item/segmented-control-item.browser.e2e.tsx | Adds browser-mode theming tests for segmented-control-item. |
| packages/components/src/components/rating/rating.e2e.ts | Removes Puppeteer theming tests for rating. |
| packages/components/src/components/rating/rating.browser.e2e.tsx | Adds browser-mode theming tests for rating. |
| packages/components/src/components/radio-button/radio-button.e2e.ts | Removes Puppeteer theming tests for radio-button. |
| packages/components/src/components/radio-button/radio-button.browser.e2e.tsx | Adds browser-mode theming tests for radio-button. |
| packages/components/src/components/radio-button-group/radio-button-group.e2e.ts | Removes Puppeteer theming tests for radio-button-group. |
| packages/components/src/components/radio-button-group/radio-button-group.browser.e2e.tsx | Adds browser-mode theming tests for radio-button-group. |
| packages/components/src/components/progress/progress.e2e.ts | Removes Puppeteer theming tests for progress. |
| packages/components/src/components/progress/progress.browser.e2e.tsx | Adds browser-mode theming tests for progress. |
| packages/components/src/components/popover/popover.e2e.ts | Removes Puppeteer theming tests for popover. |
| packages/components/src/components/popover/popover.browser.e2e.tsx | Adds browser-mode theming tests for popover. |
| packages/components/src/components/pagination/pagination.e2e.ts | Removes Puppeteer theming tests for pagination. |
| packages/components/src/components/pagination/pagination.browser.e2e.tsx | Adds browser-mode theming tests for pagination. |
| packages/components/src/components/meter/meter.e2e.ts | Removes Puppeteer theming tests for meter. |
| packages/components/src/components/meter/meter.browser.e2e.tsx | Adds browser-mode theming tests for meter. |
| packages/components/src/components/loader/loader.e2e.ts | Removes Puppeteer theming tests for loader. |
| packages/components/src/components/loader/loader.browser.e2e.tsx | Adds browser-mode theming tests for loader. |
| packages/components/src/components/list/list.e2e.ts | Removes Puppeteer theming tests for list. |
| packages/components/src/components/list/list.browser.e2e.tsx | Adds browser-mode theming tests for list. |
| packages/components/src/components/list-item-group/list-item-group.e2e.ts | Deletes Puppeteer-only theming test file for list-item-group. |
| packages/components/src/components/list-item-group/list-item-group.browser.e2e.tsx | Adds browser-mode theming tests for list-item-group. |
| packages/components/src/components/link/link.e2e.ts | Removes Puppeteer theming tests for link. |
| packages/components/src/components/link/link.browser.e2e.tsx | Adds browser-mode theming tests for link. |
| packages/components/src/components/label/label.e2e.ts | Removes Puppeteer theming tests for label. |
| packages/components/src/components/label/label.browser.e2e.tsx | Adds browser-mode theming tests for label. |
| packages/components/src/components/input/input.e2e.ts | Removes Puppeteer theming tests for input. |
| packages/components/src/components/input/input.browser.e2e.tsx | Adds browser-mode theming tests for input. |
| packages/components/src/components/input-text/input-text.e2e.ts | Removes Puppeteer theming tests for input-text. |
| packages/components/src/components/input-text/input-text.browser.e2e.tsx | Adds browser-mode theming tests for input-text. |
| packages/components/src/components/input-message/input-message.e2e.ts | Removes Puppeteer theming tests for input-message. |
| packages/components/src/components/input-message/input-message.browser.e2e.tsx | Adds browser-mode theming tests for input-message. |
| packages/components/src/components/inline-editable/inline-editable.e2e.ts | Removes Puppeteer theming tests for inline-editable. |
| packages/components/src/components/inline-editable/inline-editable.browser.e2e.tsx | Adds browser-mode theming tests for inline-editable. |
| packages/components/src/components/icon/icon.e2e.ts | Removes Puppeteer theming tests for icon. |
| packages/components/src/components/icon/icon.browser.e2e.tsx | Adds browser-mode theming tests for icon. |
| packages/components/src/components/handle/handle.e2e.ts | Removes Puppeteer theming tests for handle. |
| packages/components/src/components/handle/handle.browser.e2e.tsx | Adds browser-mode theming tests for handle. |
| packages/components/src/components/flow/flow.e2e.ts | Removes Puppeteer theming tests for flow. |
| packages/components/src/components/flow/flow.browser.e2e.tsx | Adds browser-mode theming tests for flow. |
| packages/components/src/components/flow-item/flow-item.e2e.ts | Removes Puppeteer theming tests for flow-item. |
| packages/components/src/components/flow-item/flow-item.browser.e2e.tsx | Adds browser-mode theming tests for flow-item. |
| packages/components/src/components/filter/filter.e2e.ts | Removes Puppeteer theming tests for filter. |
| packages/components/src/components/filter/filter.browser.e2e.tsx | Adds browser-mode theming tests for filter. |
| packages/components/src/components/fab/fab.e2e.ts | Removes Puppeteer theming tests for fab. |
| packages/components/src/components/fab/fab.browser.e2e.tsx | Adds browser-mode theming tests for fab. |
| packages/components/src/components/dropdown-item/dropdown-item.e2e.ts | Removes Puppeteer theming tests for dropdown-item. |
| packages/components/src/components/combobox-item/combobox-item.e2e.ts | Deletes Puppeteer-only theming test file for combobox-item. |
| packages/components/src/components/color-picker/color-picker.e2e.ts | Removes Puppeteer theming tests for color-picker. |
| packages/components/src/components/color-picker/color-picker.browser.e2e.tsx | Adds browser-mode theming tests for color-picker. |
| packages/components/src/components/chip/chip.e2e.ts | Removes Puppeteer theming tests for chip. |
| packages/components/src/components/chip/chip.browser.e2e.tsx | Adds browser-mode theming tests for chip. |
| packages/components/src/components/checkbox/checkbox.e2e.ts | Removes Puppeteer theming tests for checkbox. |
| packages/components/src/components/checkbox/checkbox.browser.e2e.tsx | Adds browser-mode theming tests for checkbox. |
| packages/components/src/components/carousel/carousel.e2e.ts | Removes Puppeteer theming tests for carousel. |
| packages/components/src/components/carousel/carousel.browser.e2e.tsx | Adds browser-mode theming tests for carousel. |
| packages/components/src/components/card/card.e2e.ts | Removes Puppeteer theming tests for card. |
| packages/components/src/components/card/card.browser.e2e.tsx | Adds browser-mode theming tests for card. |
| packages/components/src/components/card-group/card-group.e2e.ts | Removes Puppeteer theming tests for card-group. |
| packages/components/src/components/card-group/card-group.browser.e2e.tsx | Adds browser-mode theming tests for card-group. |
| packages/components/src/components/block/block.e2e.ts | Removes Puppeteer theming tests for block. |
| packages/components/src/components/block/block.browser.e2e.tsx | Adds browser-mode theming tests for block. |
| packages/components/src/components/block-section/block-section.e2e.ts | Removes Puppeteer theming tests for block-section. |
| packages/components/src/components/block-section/block-section.browser.e2e.tsx | Adds browser-mode theming tests for block-section. |
| packages/components/src/components/avatar/avatar.e2e.ts | Removes Puppeteer theming tests for avatar. |
| packages/components/src/components/avatar/avatar.browser.e2e.tsx | Adds browser-mode theming tests for avatar. |
| packages/components/src/components/autocomplete/autocomplete.e2e.ts | Removes Puppeteer theming tests for autocomplete. |
| packages/components/src/components/autocomplete/autocomplete.browser.e2e.tsx | Adds browser-mode theming tests for autocomplete. |
| packages/components/src/components/autocomplete-item/autocomplete-item.e2e.ts | Deletes Puppeteer-only theming test file for autocomplete-item. |
| packages/components/src/components/autocomplete-item/autocomplete-item.browser.e2e.tsx | Adds browser-mode theming tests for autocomplete-item. |
| packages/components/src/components/autocomplete-item-group/autocomplete-item-group.e2e.ts | Deletes Puppeteer-only theming test file for autocomplete-item-group. |
| packages/components/src/components/autocomplete-item-group/autocomplete-item-group.browser.e2e.tsx | Adds browser-mode theming tests for autocomplete-item-group. |
| packages/components/src/components/alert/alert.e2e.ts | Removes Puppeteer theming tests for alert. |
| packages/components/src/components/alert/alert.browser.e2e.tsx | Adds browser-mode theming tests for alert. |
| packages/components/src/components/action-pad/action-pad.e2e.ts | Removes Puppeteer theming tests for action-pad. |
| packages/components/src/components/action-pad/action-pad.browser.e2e.tsx | Adds browser-mode theming tests for action-pad. |
| packages/components/src/components/action-menu/action-menu.e2e.ts | Removes Puppeteer theming tests for action-menu. |
| packages/components/src/components/action-menu/action-menu.browser.e2e.tsx | Adds browser-mode theming tests for action-menu. |
| packages/components/src/components/action-group/action-group.e2e.ts | Removes Puppeteer theming tests for action-group. |
| packages/components/src/components/action-group/action-group.browser.e2e.tsx | Adds browser-mode theming tests for action-group. |
| packages/components/src/components/action-bar/action-bar.e2e.ts | Removes Puppeteer theming tests for action-bar. |
| packages/components/src/components/action-bar/action-bar.browser.e2e.tsx | Adds browser-mode theming tests for action-bar. |
| packages/components/src/components/accordion/accordion.e2e.ts | Removes Puppeteer theming tests for accordion. |
| packages/components/src/components/accordion/accordion.browser.e2e.tsx | Adds browser-mode theming tests for accordion. |
| packages/components/src/components/accordion-item/accordion-item.e2e.ts | Removes Puppeteer theming tests for accordion-item. |
| packages/components/src/components/accordion-item/accordion-item.browser.e2e.tsx | Adds browser-mode theming tests for accordion-item. |
...es/components/src/components/autocomplete-item-group/autocomplete-item-group.browser.e2e.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
1
to
4
| export { accessible } from "./accessible"; | ||
| export { formAssociated } from "./formAssociated"; | ||
| export { labelable } from "./labelable"; | ||
| export { themed } from "./themed"; | ||
| export { HYDRATED_ATTR } from "./puppeteer/utils"; |
packages/components/src/components/action-group/action-group.browser.e2e.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/block-section/block-section.browser.e2e.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.