Fix OSC 11 background color reporting#11074
Open
uadhran wants to merge 1 commit intoEugeny:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the terminal background color reported through
OSC 11[ #10121 ].Tabby was sometimes passing a transparent/null background through to xterm when the terminal was following the app theme. In that case,
OSC 11could report black instead of the actual background color.This change keeps the existing host background behavior, but makes sure xterm always receives a concrete background color for its internal theme.
Changes
getTerminalBackgroundColor()for the outer terminal containerTesting
eslinttabby-terminalsuccessfully with webpackNotes
This should mainly affect background color reporting and similar xterm internals. The visible terminal background behavior should remain unchanged.