Skip to content

fix: use switchMap instead of flatMap for plugin search to prevent st… #11089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varunsub wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

fix: use switchMap instead of flatMap for plugin search to prevent st… #11089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tabby-plugin-manager/src/components/pluginsSettingsTab.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable @typescript-eslint/explicit-module-boundary-types */
import { marker as _ } from '@biesbjerg/ngx-translate-extract-marker'
import { BehaviorSubject, Observable, debounceTime, distinctUntilChanged, first, tap, flatMap, map } from 'rxjs'
import { BehaviorSubject, Observable, debounceTime, distinctUntilChanged, first, tap, switchMap, map } from 'rxjs'
import semverGt from 'semver/functions/gt'

import { Component, HostBinding, Input } from '@angular/core'
Expand Down Expand Up @@ -48,7 +48,7 @@ export class PluginsSettingsTabComponent {
.pipe(
debounceTime(200),
distinctUntilChanged(),
flatMap(query => {
switchMap(query => {
this.availablePluginsReady = false
return this.pluginManager.listAvailable(query).pipe(tap(() => {
this.availablePluginsReady = true
Expand All @@ -69,7 +69,7 @@ export class PluginsSettingsTabComponent {
.pipe(
debounceTime(200),
distinctUntilChanged(),
flatMap(query => {
switchMap(query => {
return this.pluginManager.listInstalled(query)
}),
).subscribe(plugin => {
Expand Down
Loading