perf: fix UI degradation with large SSH config files. Issue #11078

tabby-core/src/directives/fastHtmlBind.directive.ts

@@ -7,13 +7,18 @@ import { PlatformService } from '../api/platform'
 })
 export class FastHtmlBindDirective implements OnChanges {
     @Input() fastHtmlBind?: string
+    private _lastValue?: string
 
     constructor (
         private el: ElementRef,
         private platform: PlatformService,
     ) { }
 
     ngOnChanges (): void {
+        if (this.fastHtmlBind === this._lastValue) {
+            return
+        }
+        this._lastValue = this.fastHtmlBind
         this.el.nativeElement.innerHTML = this.fastHtmlBind ?? ''
         for (const link of this.el.nativeElement.querySelectorAll('a')) {
             link.addEventListener('click', event => {

tabby-core/src/services/profiles.service.ts

@@ -14,7 +14,7 @@ import slugify from 'slugify'
 
 @Injectable({ providedIn: 'root' })
 export class ProfilesService {
-    private profileDefaults: Profile = {
+    private profileDefaults = {
         id: '',
         type: '',
         name: '',
@@ -26,6 +26,7 @@ export class ProfilesService {
         weight: 0,
         isBuiltin: false,
         isTemplate: false,
+        terminalColorScheme: null,
         behaviorOnSessionEnd: 'auto',
     }
 
@@ -52,8 +53,8 @@ export class ProfilesService {
     }
 
     getDescription <P extends Profile> (profile: PartialProfile<P>): string|null {
-        profile = this.getConfigProxyForProfile(profile) as PartialProfile<P>
-        return this.providerForProfile(profile)?.getDescription(profile) ?? null
+        const fullProfile = this.getConfigProxyForProfile(profile)
+        return this.providerForProfile(fullProfile)?.getDescription(fullProfile) ?? null
     }
 
     /*
@@ -65,7 +66,7 @@ export class ProfilesService {
     * arg: skipUserDefaults -> do not merge global provider defaults in ConfigProxy
     * arg: skipGroupDefaults -> do not merge parent group provider defaults in ConfigProxy
     */
-    getConfigProxyForProfile <P extends Profile> (profile: PartialProfile<P>, options?: { skipGlobalDefaults?: boolean, skipGroupDefaults?: boolean }): FullyDefined<P> & ConfigProxy<FullyDefined<P>> {
+    getConfigProxyForProfile <T extends Profile> (profile: PartialProfile<T>, options?: { skipGlobalDefaults?: boolean, skipGroupDefaults?: boolean }): FullyDefined<T> & ConfigProxy<FullyDefined<T>> {
         const defaults = this.getProfileDefaults(profile, options).reduce(configMerge, {})
         return new ConfigProxy(profile, defaults) as any
     }
@@ -213,10 +214,9 @@ export class ProfilesService {
         const provider = this.providerForProfile(fullProfile)
         const freeInputEquivalent = provider instanceof QuickConnectProfileProvider ? provider.intoQuickConnectString(fullProfile) ?? undefined : undefined
         return {
-            name: profile.name,
+            ...profile,
             icon: profile.icon ?? undefined,
             color: profile.color ?? undefined,
-            weight: profile.weight,
             group: this.resolveProfileGroupName(profile.group ?? ''),
             freeInputEquivalent,
             description: provider?.getDescription(fullProfile),
@@ -510,7 +510,7 @@ export class ProfilesService {
     * arg: skipUserDefaults -> do not merge global provider defaults in ConfigProxy
     */
     getProviderProfileGroupDefaults (groupId: string, provider: ProfileProvider<Profile>): any {
-        return this.getSyncProfileGroups().find(g => g.id === groupId)?.defaults?.[provider.id] ?? {}
+        return (this.config.store.groups ?? []).find(g => g.id === groupId)?.defaults?.[provider.id] ?? {}
     }
 
 }

tabby-electron/src/shells/windowsStock.ts

@@ -72,22 +72,26 @@ export class WindowsStockShellsProvider extends WindowsBaseShellProvider {
     }
 
     private async getPowerShellPath () {
-        for (const name of ['pwsh.exe', 'powershell.exe']) {
-            if (await which(name, { nothrow: true })) {
-                return name
-            }
-        }
+        // Check well-known paths first to avoid slow PATH scanning via `which`
         for (const psPath of [
             `${process.env.USERPROFILE}\\AppData\\Local\\Microsoft\\WindowsApps\\pwsh.exe`,
+            `${process.env.ProgramFiles}\\PowerShell\\7\\pwsh.exe`,
+            `${process.env['ProgramFiles(x86)']}\\PowerShell\\7\\pwsh.exe`,
             `${process.env.SystemRoot}\\System32\\WindowsPowerShell\\v1.0\\powershell.exe`,
             `${process.env.SystemRoot}\\System32\\powershell.exe`,
-            (process.env.SystemRoot ?? 'C:\\Windows') + '\\powerhshell.exe',
         ]) {
             try {
                 await fs.stat(psPath)
                 return psPath
             } catch { }
         }
+        // Fall back to PATH search only if not found in standard locations
+        for (const name of ['pwsh.exe', 'powershell.exe']) {
+            const found = await which(name, { nothrow: true })
+            if (found) {
+                return found
+            }
+        }
         return 'powershell.exe'
     }
 }

tabby-electron/src/sshImporters.ts

@@ -11,7 +11,7 @@
     SSHProfile,
     AutoPrivateKeyLocator,
     ForwardedPortConfig,
 } from 'tabby-ssh'
 
 import { ElectronService } from './services/electron.service'
 import SSHConfig, { Directive, LineType } from 'ssh-config'
@@ -354,21 +354,72 @@
 }
 
 
+let _openSSHCache: PartialProfile<SSHProfile>[] | null = null
+let _openSSHCacheMtime: number | null = null
+let _openSSHCachePromise: Promise<PartialProfile<SSHProfile>[]> | null = null
+
+interface SSHProfileDiskCache {
+    mtime: number
+    profiles: PartialProfile<SSHProfile>[]
+}
+
 @Injectable({ providedIn: 'root' })
 export class OpenSSHImporter extends SSHProfileImporter {
+    private diskCachePath: string
+
+    constructor (electron: ElectronService) {
+        super()
+        this.diskCachePath = path.join(electron.app.getPath('userData'), 'ssh-profiles-cache.json')
+    }
+
     async getProfiles (): Promise<PartialProfile<SSHProfile>[]> {
+        if (_openSSHCachePromise) {
+            return _openSSHCachePromise
+        }
 
         const configPath = path.join(process.env.HOME ?? '~', '.ssh', 'config')
 
-        try {
-            const config: SSHConfig = await parseSSHConfigFile(configPath)
-            return await convertToSSHProfiles(config)
-        } catch (e) {
-            if (e.code === 'ENOENT') {
-                return []
+        _openSSHCachePromise = (async () => {
+            try {
+                const stat = await fs.stat(configPath)
+                const mtime = stat.mtimeMs
+
+                if (_openSSHCache && _openSSHCacheMtime === mtime) {
+                    return _openSSHCache
+                }
+
+                // Try disk cache first
+                try {
+                    const diskCache: SSHProfileDiskCache = JSON.parse(
+                        await fs.readFile(this.diskCachePath, 'utf8'),
+                    )
+                    if (diskCache.mtime === mtime) {
+                        _openSSHCache = diskCache.profiles
+                        _openSSHCacheMtime = mtime
+                        return _openSSHCache
+                    }
+                } catch { /* no cache or invalid */ }
+
+                const config: SSHConfig = await parseSSHConfigFile(configPath)
+                _openSSHCache = await convertToSSHProfiles(config)
+                _openSSHCacheMtime = mtime
+
+                // Save to disk cache (fire and forget)
+                fs.writeFile(this.diskCachePath, JSON.stringify({ mtime, profiles: _openSSHCache }))
+                    .catch(() => { /* ignore write errors */ })
+
+                return _openSSHCache
+            } catch (e) {
+                if (e.code === 'ENOENT') {
+                    return []
+                }
+                throw e
+            } finally {
+                _openSSHCachePromise = null
             }
-            throw e
-        }
+        })()
+
+        return _openSSHCachePromise
     }
 }
 

tabby-settings/src/components/profilesSettingsTab.component.ts

@@ -26,6 +26,7 @@ export class ProfilesSettingsTabComponent extends BaseComponent {
     profileGroups: PartialProfileGroup<CollapsableProfileGroup>[]
     filter = ''
     Platform = Platform
+    private descriptionCache = new Map<string, string|null>()
 
     constructor (
         public config: ConfigService,
@@ -49,10 +50,17 @@ export class ProfilesSettingsTabComponent extends BaseComponent {
     }
 
     async refreshProfiles (): Promise<void> {
-        this.builtinProfiles = (await this.profilesService.getProfiles()).filter(x => x.isBuiltin)
-        this.customProfiles = (await this.profilesService.getProfiles()).filter(x => !x.isBuiltin)
-        this.templateProfiles = this.builtinProfiles.filter(x => x.isTemplate)
-        this.builtinProfiles = this.builtinProfiles.filter(x => !x.isTemplate)
+        const allProfiles = await this.profilesService.getProfiles()
+        this.builtinProfiles = allProfiles.filter(x => x.isBuiltin && !x.isTemplate)
+        this.templateProfiles = allProfiles.filter(x => x.isBuiltin && x.isTemplate)
+        this.customProfiles = allProfiles.filter(x => !x.isBuiltin)
+
+        this.descriptionCache.clear()
+        for (const p of allProfiles) {
+            if (p.id) {
+                this.descriptionCache.set(p.id, this.profilesService.getDescription(p))
+            }
+        }
     }
 
     launchProfile (profile: PartialProfile<Profile>): void {
@@ -265,6 +273,9 @@ export class ProfilesSettingsTabComponent extends BaseComponent {
     }
 
     getDescription (profile: PartialProfile<Profile>): string|null {
+        if (profile.id) {
+            return this.descriptionCache.get(profile.id) ?? null
+        }
         return this.profilesService.getDescription(profile)
     }