Skip to content

re: HoloAPI#1

Open
cnr wants to merge 6 commits intoEuropia79:masterfrom
cnr:holofix
Open

re: HoloAPI#1
cnr wants to merge 6 commits intoEuropia79:masterfrom
cnr:holofix

Conversation

@cnr
Copy link
Copy Markdown

@cnr cnr commented Aug 20, 2014

This is untested.

I'm not in a position to test this (and won't be until next week when I get my development machine back), but this should help resolve the issue you were having with HoloAPI.

@Europia79
Copy link
Copy Markdown
Owner

Oh sweet, thanks! i'll test it out real quick.

@cnr
Copy link
Copy Markdown
Author

cnr commented Aug 20, 2014

Errh I should've applied this to R2 or R3; this won't work for R4. Hold on a sec; I'll fix it for R4

@cnr
Copy link
Copy Markdown
Author

cnr commented Aug 20, 2014

Updated the commit. To apply this to previous versions, you should be able to simply paste in the VPPlayerConnection class and call VPPlayerConnection.wrap(getHandle()) in the VirtualPlayer constructor(s).

(again assuming this even works at all)

@Europia79
Copy link
Copy Markdown
Owner

it won't build... Gimme a second to import it and fix it. Then i'll test against 1_7_R4. If that doesn't work, i'll paste over 1_7_R1 and test... And see if we get any errors.

@Europia79
Copy link
Copy Markdown
Owner

[INFO] Reactor Summary:
[INFO]
[INFO] VirtualPlayers Parent POM ......................... SUCCESS [ 0.119 s]
[INFO] virtualplayers-util ............................... SUCCESS [ 1.730 s]
[INFO] virtualplayers-vPre ............................... SUCCESS [ 0.754 s]
[INFO] virtualplayers-v1_4_5 ............................. SUCCESS [ 0.782 s]
[INFO] virtualplayers-v1_4_6 ............................. SUCCESS [ 0.649 s]
[INFO] virtualplayers-v1_4_R1 ............................ SUCCESS [ 0.516 s]
[INFO] virtualplayers-v1_5_R1 ............................ SUCCESS [ 0.844 s]
[INFO] virtualplayers-v1_5_R2 ............................ SUCCESS [ 0.504 s]
[INFO] virtualplayers-v1_5_R3 ............................ SUCCESS [ 0.489 s]
[INFO] virtualplayers-v1_6_R1 ............................ SUCCESS [ 0.681 s]
[INFO] virtualplayers-v1_6_R2 ............................ SUCCESS [ 0.501 s]
[INFO] virtualplayers-v1_6_R3 ............................ SUCCESS [ 0.480 s]
[INFO] virtualplayers-v1_7_R1 ............................ SUCCESS [ 0.573 s]
[INFO] virtualplayers-v1_7_R2 ............................ SUCCESS [ 0.683 s]
[INFO] virtualplayers-v1_7_R3 ............................ SUCCESS [ 0.500 s]
[INFO] virtualplayers-v1_7_R4 ............................ FAILURE [ 0.477 s]
[INFO] VirtualPlayers .................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.447 s
[INFO] Finished at: 2014-08-20T11:40:48-06:00
[INFO] Final Memory: 40M/482M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.
1:compile (default-compile) on project vp-v1_7_R4: Compilation failure
[ERROR] /C:/Users/Nikolai/Desktop/VirtualPlayers-holofix/VirtualPlayers-holofix/
modules/v1_7_R4/src/main/java/mc/alk/virtualplayers/nms/v1_7_R4/VPPlayerConnecti
on.java:[59,22] C:\Users\Nikolai\Desktop\VirtualPlayers-holofix\VirtualPlayers-h
olofix\modules\v1_7_R4\src\main\java\mc\alk\virtualplayers\nms\v1_7_R4\VPPlayerC
onnection.java:59: cannot find symbol
[ERROR] symbol: class ReflectiveOperationException
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e swit
ch.

@cnr
Copy link
Copy Markdown
Author

cnr commented Aug 20, 2014

Hmm compiles locally for me. maybe change ReflectiveOperationException to IllegalAccessException? shrug

I'll hop in DSH's IRC channel

@cnr
Copy link
Copy Markdown
Author

cnr commented Aug 28, 2014

Successfully tested with 1_7_R4 against the latest HoloAPI build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants