fix(schema): allow nullish EventType in BaseEvents#118
Merged
Conversation
Change EventType from .nullable() to .nullish() to support existing wikis where eventType is null or undefined in the database.
🦋 Changeset detectedLatest commit: 95eaa40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the BaseEvents schema in src/schema/index.ts to allow the type field to be nullish instead of nullable, facilitating compatibility with existing wikis that contain null event types. I have no feedback to provide as the changes are straightforward and correctly implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventTypefrom.nullable()to.nullish()inBaseEventsschemaeventTypeisnullorundefinedin the databaseTest plan
closes https://github.com/EveripediaNetwork/issues/issues/4826