[HOLD Auth#20979] Add handwritten receipt prohibited expense toggle#87533
[HOLD Auth#20979] Add handwritten receipt prohibited expense toggle#87533
Conversation
Co-authored-by: Daniel Gale-Rosen <dangrous@users.noreply.github.com>
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: The diff is too large to include in this comment (63KB), so I've created a gist for you: 📋 View the translation diff here 📋 Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54cfdb962e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/languages/it.ts
Outdated
| case ‘hotelIncidentals’: | ||
| return `spese accessorie dell’hotel`; | ||
| case ‘handwrittenReceipt’: |
There was a problem hiding this comment.
Replace smart quotes in Italian switch cases
The new case labels use typographic quotes (‘…’) instead of JavaScript string delimiters ('…'), which makes src/languages/it.ts invalid syntax and will break TypeScript/JS parsing during bundling. In any build that imports this translations file (including normal app startup), the bundle can fail to compile before runtime behavior is reached.
Useful? React with 👍 / 👎.
…tatements Co-authored-by: Daniel Gale-Rosen <dangrous@users.noreply.github.com>
|
Fixed the failing typecheck: |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Sorry, Melv shouldn't have put this in review yet, we need some other bits and pieces first. |
Summary
handwrittenReceipttoggle to the prohibited expenses UI in workspace rules settingsChanges
HANDWRITTEN_RECEIPTtoPROHIBITED_EXPENSEShandwrittenReceipttoProhibitedExpensestypeRelated PRs
Test plan
handwrittenReceiptkey