Add gift card purchase prohibited expense toggle#87534
Add gift card purchase prohibited expense toggle#87534
Conversation
Co-authored-by: Daniel Gale-Rosen <dangrous@users.noreply.github.com>
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: The diff is too large to include in this comment (64KB), so I've created a gist for you: 📋 View the translation diff here 📋 Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c41346b1f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/languages/it.ts
Outdated
| case 'adultEntertainment': | ||
| return `intrattenimento per adulti`; | ||
| case 'hotelIncidentals': | ||
| case ‘hotelIncidentals’: |
There was a problem hiding this comment.
Use ASCII quotes in Italian prohibited expense switch
The new case label uses typographic quotes (‘hotelIncidentals’) instead of normal JavaScript string delimiters, which makes src/languages/it.ts invalid syntax and prevents the bundle from parsing this module at build/runtime. Because the translations files are imported as code (not data), this breaks app startup universally until the quotes are changed back to '...' (and the same issue on the added giftCard case should be corrected too).
Useful? React with 👍 / 👎.
The original commit introduced Unicode smart quotes (U+2018/U+2019) in case statement string delimiters in it.ts, which are not valid JavaScript syntax. This caused Prettier and TypeScript check failures. Co-authored-by: Daniel Gale-Rosen <dangrous@users.noreply.github.com>
|
Fixed the failing Prettier and TypeScript checks. The original commit had Unicode smart quotes ( |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@dangrous you'll need to do the author checklist here |
Summary
giftCardtoggle to the prohibited expenses UI in workspace rules settingsChanges
GIFT_CARDtoPROHIBITED_EXPENSESgiftCardtoProhibitedExpensestypeRelated PRs
Test plan
giftCardkey