Preserve distance rate for unreported expenses from non-default policies#87537
Draft
Preserve distance rate for unreported expenses from non-default policies#87537
Conversation
When a distance request is unreported from a report tied to a non-default policy, resolve the policy that owns the customUnitRateID and use it instead of the default moving-expenses policy. This mirrors the existing pattern for perDiem requests. Co-authored-by: Cristi Paval <cristipaval@users.noreply.github.com>
7 tasks
Contributor
Author
|
The failing check is unrelated to this PR. Failing test: Analysis: This PR only modifies Evidence: This appears to be a pre-existing/flaky test failure. The PR's changes have no connection to profile page contact methods or brick road indicators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a distance request is unreported from a report tied to a non-default policy, the distance rate was being lost because the unreported expense was associated with the user's default policy (
policyForMovingExpenses), which doesn't contain the originalcustomUnitRateID.This PR applies the same pattern already used for perDiem requests: resolve the policy that owns the
customUnitRateIDand use it instead of the default policy. Specifically:PolicyUtils.ts: AddedgetPolicyByCustomUnitRateID()— searches all policies for one whose distance custom unit contains the transaction'scustomUnitRateID(mirrorsgetPolicyByCustomUnitIDfor perDiem).MoneyRequestView.tsx: For unreported distance requests, resolve the policy via the new function so the correct rate and policy are passed to the backend.usePolicyForTransaction.ts: Extended the self-DM expense policy resolution to also handle distance requests by looking up the policy that owns thecustomUnitRateID.Fixed Issues
$ #87204
PROPOSAL: #87204 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - Logic-only change, no UI modifications
Android: mWeb Chrome
N/A - Logic-only change, no UI modifications
iOS: Native
N/A - Logic-only change, no UI modifications
iOS: mWeb Safari
N/A - Logic-only change, no UI modifications
MacOS: Chrome / Safari
N/A - Logic-only change, no UI modifications
Checks run:
prettier— pass (no formatting changes)eslint— pass (pre-existing warning in PolicyUtils.ts line 76 unrelated to this PR)typecheck— passjest(PolicyUtils, MoneyRequestView tests) — pass (151 tests)Co-authored-by: cristipaval cristipaval@users.noreply.github.com