Skip to content

[HOLD] cross-device passkey testing PR #87551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chuckdries wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −10
Draft

[HOLD] cross-device passkey testing PR #87551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions src/components/MultifactorAuthentication/biometrics/usePasskeys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ function usePasskeys(): UseBiometricsReturn {
const hasLocalCredentials = async () => (localPasskeyCredentials?.length ?? 0) > 0;

const areLocalCredentialsKnownToServer = async () => {
const serverSet = new Set(serverKnownCredentialIDs);
return (localPasskeyCredentials ?? []).some((c) => serverSet.has(c.id));
// const serverSet = new Set(serverKnownCredentialIDs);
// return (localPasskeyCredentials ?? []).some((c) => serverSet.has(c.id));
return serverKnownCredentialIDs.length > 0;
};

const deleteLocalKeysForAccount = async () => {
Expand Down Expand Up @@ -113,22 +114,22 @@ function usePasskeys(): UseBiometricsReturn {
const authorize = async (params: AuthorizeParams, onResult: (result: AuthorizeResult) => Promise<void> | void) => {
const {challenge} = params;

const backendCredentials = challenge.allowCredentials?.map((c) => ({id: c.id, type: CONST.PASSKEY_CREDENTIAL_TYPE})) ?? [];
const reconciled = reconcileLocalPasskeysWithBackend({
userId,
backendCredentials,
localCredentials: localPasskeyCredentials ?? null,
});
const serverCredentials = challenge.allowCredentials?.map((c) => ({id: c.id, type: CONST.PASSKEY_CREDENTIAL_TYPE, transports: c.transports?.filter(isSupportedTransport)})) ?? [];
// const reconciled = reconcileLocalPasskeysWithBackend({
// userId,
// backendCredentials,
// localCredentials: localPasskeyCredentials ?? null,
// });

if (reconciled.length === 0) {
if (serverCredentials.length === 0) {
await onResult({
success: false,
reason: VALUES.REASON.WEBAUTHN.REGISTRATION_REQUIRED,
});
return;
}

const allowCredentials = buildAllowedCredentialDescriptors(reconciled);
const allowCredentials = buildAllowedCredentialDescriptors(serverCredentials);
const publicKeyOptions = buildPublicKeyCredentialRequestOptions(challenge, allowCredentials);

let assertion: PublicKeyCredential;
Expand Down
Loading