[Payment due @situchan] Hide ACH if report is non reimbursable#87552
[Payment due @situchan] Hide ACH if report is non reimbursable#87552s77rt wants to merge 9 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Ah the decision was changed so quickly 😅 |
|
Can we show "Mark as paid" directly instead of 2 steps - "Pay $x.xx" > "Mark $x.xx as paid"? Screen.Recording.2026-04-10.at.8.48.12.AM.movRepro step:
|
|
Above suggestion is product change so maybe out of scope. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.mp4Android: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariScreen.Recording.2026-04-11.at.2.12.03.AM.movMacOS: Chrome / Safariweb.mov |
|
Let's just fix |
|
I agree with #87552 (comment) btw, "Pay $0.00" is weird. |
|
@joekaufmanexpensify do you want to do the product review on this? |
|
Sure |
This reverts commit 8ad30eb.
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
I am also good with |
|
One thing I noticed. We aren't showing these as reports that have to be paid in the 2026-04-10_16-00-17.mp4 |
|
Can we create separate issue and PR for that? LHN badge/pinned issue has different root cause and out of scope for this PR which already became large enough. |
|
🎯 @situchan, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
Explanation of Change
Hide ACH if report is non reimbursable. The only option that should be shown for such a case is to mark the report as paid (given that policy has payments enabled).
This PR reverts some changes from #83329 mainly the part where users where allowed to choose ACH option then they get a modal when they try to pay with ACH. Now the ACH option is no longer an option.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/622532
PROPOSAL:
Tests
Screen.Recording.2026-04-10.at.2.34.58.AM.mov
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari