Fix types and units for inherited fields in MPES#373
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Here's the draft for inheritance of fields and attributes that led to these inconsistencies being detected: FAIRmat-NFDI/pynxtools#621 |
rettigl
approved these changes
Apr 9, 2025
rettigl
left a comment
Collaborator
There was a problem hiding this comment.
Changes make sense to me.
Generally, with our current implementation I see restriction to NX_FLOAT at various places a bit problematic, if one does not have influence on the data type of some fields, i.e. would have to change the reader for that. So I am wondering if it would not make sense to introduce silten int to float conversion for NX_FLOAT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting to build sibling inheritance in the NexusTree of pynxtools, I found these small inconsistencies where fields in MPES-related appdefs had mismatches to the same fields defined in base classes or in the MPES application definition.
Summary by Sourcery
Fix field type and unit inconsistencies in MPES and XPS NeXus definitions
Bug Fixes:
Enhancements: