forked from PyPSA/linopy
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add incremental piecewise linear formulation #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FBumann
wants to merge
5
commits into
feat/add-piecewise-linear-clean
Choose a base branch
from
feat/add-piecewise-linear-clean+linear
base: feat/add-piecewise-linear-clean
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
302d92b
linopy/constants.py — Added PWL_DELTA_SUFFIX = "_delta" and PWL_FIL…
FBumann 6e76739
1. Step sizes: replaced manual loop + xr.concat with breakpoints.di…
FBumann 36112e2
rewrite filling order constraint
FBumann ec4538b
Fix monotonicity check
FBumann c1fe342
docs: add piecewise linear constraints documentation (SOS2 + incremen…
FBumann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 73
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 946
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 3546
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 73
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 1423
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 3246
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 92
🏁 Script executed:
# Check imports to understand what DataArray is head -50 linopy/model.pyRepository: FBumann/linopy
Length of output: 1157
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 3313
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 1619
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 1424
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 40
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 876
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 40
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 801
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 5197
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 2503
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 176
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 176
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 602
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 678
🏁 Script executed:
Repository: FBumann/linopy
Length of output: 1574
Fix monotonicity check to support per-variable directions and handle masked NaNs.
The current implementation incorrectly rejects valid cases where:
The check evaluates monotonicity globally across the full DataArray, but should evaluate per slice along
dimto allow independent monotonic directions. NaN diffs should be ignored.🛠️ Suggested fix
🤖 Prompt for AI Agents