Modern CMake review#1036
Merged
Merged
Conversation
- Use target property WINDOWS_EXPORT_ALL_SYMBOLS instead of global CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS; drop redundant if(WIN32) guard - Remove redundant PRIVATE include of CMAKE_CURRENT_BINARY_DIR already covered by the PUBLIC BUILD_INTERFACE generator expression - Use relative paths in target_sources and HEADERS_basix list - Merge split set_target_properties, target_compile_definitions, and target_link_libraries calls; add VERSION/SOVERSION properties - Explicitly initialise BASIX_CXX_DEVELOPER_FLAGS/DEFINITIONS before list(APPEND) calls - Remove unnecessary quotes from project() VERSION string Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Use target property WINDOWS_EXPORT_ALL_SYMBOLS on _basixcpp instead of global CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS; drop if(WIN32) guard - Explicitly initialise BASIX_PY_CXX_DEVELOPER_FLAGS/DEFINITIONS before list(APPEND) calls - Add -pipe compiler flag check to match cpp/CMakeLists.txt - Merge split target_compile_definitions calls for MDSPAN defines - Replace deprecated get_filename_component with cmake_path(GET ... PARENT_PATH) - Change option default TRUE -> ON for conventional style Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few small improvements proposed by Claude Sonnet 4.6