Skip to content

Test cases for strict identifier system validation #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmckenzi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test cases for strict identifier system validation #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e3a4eb
Test cases for strict identifier system validation
lmckenzi Oct 9, 2025
52e74d4
Merge branch 'master' of https://github.com/FHIR/fhir-test-cases into…
lmckenzi Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion r5/capabilitystatement-import/CapabilityStatement-1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,11 @@
</operation>
</rest>
<messaging>
<reliableCache value="10"/>
<reliableCache value="10">
<extension url="http://hl7.org/fhir/StructureDefinition/capabilitystatement-expectation">
<valueCode value="SHOULD"/>
</extension>
</reliableCache>
<documentation value="Whatever"/>
<supportedMessage>
<extension url="http://hl7.org/fhir/StructureDefinition/capabilitystatement-expectation">
Expand Down
6 changes: 5 additions & 1 deletion r5/capabilitystatement-import/CapabilityStatement-2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,11 @@
</protocol>
<address value="http://example.org/endpoint2"/>
</endpoint>
<reliableCache value="20"/>
<reliableCache value="20">
<extension url="http://hl7.org/fhir/StructureDefinition/capabilitystatement-expectation">
<valueCode value="SHALL"/>
</extension>
</reliableCache>
<documentation value="Whatever"/>
<supportedMessage>
<extension url="http://hl7.org/fhir/StructureDefinition/capabilitystatement-expectation">
Expand Down
10 changes: 10 additions & 0 deletions validator/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
" * 'use-test': set to false and the test will be ignored",
" * 'version': the version being validated. values: 1.0, 1.4, 3.0, 4.0. If no version specified, that means current R5",
" * 'assumeValidRestReferences' : default = false",
" * 'strictIdentifierSystems' : default = false",
" * 'allowed-extension-domain' : Extension URls from this domain are ok",
" * 'best-practice': How to treat best practice warnings. missing: ignored, else one of Hint, Warning, or Error",
" * 'language': the language to validate with. If unspecified, this defaults to the language of the resource, then to english. This has the same syntax and semantics as the Accept-Language header",
Expand Down Expand Up @@ -11663,6 +11664,15 @@
"module": "profile",
"java": "java/R4.bundle-resolve-deep.json"
},
{
"name": "identifier-systems",
"file": "patient-identifiers.xml",
"description": "Check that identifier systems are valid",
Copy link
Copy Markdown
Collaborator

@grahamegrieve grahamegrieve Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not valid, it's 'declared'

"version": "4.0",
"module": "(default)",
"strictIdentifierSystems": true,
"java": "java/R4.identifier-systems-base.json"
},
{
"name": "zzz",
"file": "zzz.json",
Expand Down
12 changes: 12 additions & 0 deletions validator/outcomes/java/R4.identifier-systems-base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"resourceType": "OperationOutcome",
"issue" : [{
"severity" : "information",
"code" : "business-rule",
"details" : {
"text" : "Identifier.system is not based on example.org or example.com and is not a preferred URI of any identifier system NamingSystems. Ensure that the Identifier.system value is a properly defined system value"
Copy link
Copy Markdown
Collaborator

@grahamegrieve grahamegrieve Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this language is a problem. It should be 'chcek' not 'ensure' - it's not wrong to use something for which there's no NamingSystem. Or maybe it should say 'best practice is to declare the system in a NamingSystem resource'

},
"diagnostics" : "[8,14]",
"expression" : ["Patient.identifier[0]"]
}]
}
24 changes: 24 additions & 0 deletions validator/patient-identifiers.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?xml version="1.0" encoding="UTF-8"?>
<Patient xmlns="http://hl7.org/fhir">
<id value="exampleidentifiers"/>
<text>
<status value="generated"/>
<div xmlns="http://www.w3.org/1999/xhtml">N/A</div>
</text>
<identifier>
<!-- This is unrecognized and should trigger a message -->
<system value="urn:oid:1.2.36.146.595.217.0.1"/>
<value value="Unrecognized"/>
</identifier>
<identifier>
<!-- This is an example system -->
<system value="http://example.org/someIdentifier"/>
<value value="thisisfine"/>
</identifier>
<identifier>
<!-- This is a registered system -->
<system value="http://hl7.org/fhir/sid/us-ssn"/>
<value value="123456789"/>
</identifier>
<active value="true"/>
</Patient>