Skip to content

Fix resetting of fields on config update to avoid visual desync #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabeStuk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix resetting of fields on config update to avoid visual desync #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/store/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export const useQRScoutState = createStore<QRScoutState>(
);

export function resetToDefaultConfig() {
forceResetFields(); // clicking 'x' instead of Save can prevent a `setFormData` call
useQRScoutState.setState(initialState);
}

Expand Down Expand Up @@ -119,12 +120,12 @@ export function getFieldValue(code: string) {
}

export function resetFields() {
window.dispatchEvent(new CustomEvent('resetFields', { detail: 'reset' }));
window.dispatchEvent(new CustomEvent('resetFields', { detail: { force: false } }));
}

export function forceResetFields() {
window.dispatchEvent(
new CustomEvent('forceResetFields', { detail: 'forceReset' }),
new CustomEvent('resetFields', { detail: { force: true } }),
);
}

Expand Down