Antoine/swift6#11
Conversation
TODO: Basically check all the "unchecked @sendable"
| @@ -400,7 +400,6 @@ | |||
| 4B2D586A25346C730080E958 /* Frameworks */, | |||
There was a problem hiding this comment.
Basically just apply recommended changes and swift 6
| import AVFoundation | ||
| import Foundation | ||
|
|
||
| public actor CaptureBody { |
There was a problem hiding this comment.
It's illegal to perform start/stop running in between session configurations. Session is also non sendable. Ensure all access is done sequentially.
It also should happen in background (previously could be performed on main thread).
Technically it can still hop on different threads, which could be an issue ?
| import Foundation | ||
| import os | ||
|
|
||
| public final class EventBusCancellable: Hashable { |
There was a problem hiding this comment.
I don't see any potential for concurrency issue here
| } | ||
| } | ||
|
|
||
| /// [non-atomic] |
There was a problem hiding this comment.
Ensure all array operations are non concurrent, which could be an issue with the previous design.
| } | ||
|
|
||
| public func setUp(sessionInConfiguring: AVCaptureSession) { | ||
| // Are those actually thread safe ? |
There was a problem hiding this comment.
NB: no particular mention in the documentation.
|
|
||
| pod 'MondrianLayout' | ||
| pod 'Reveal-SDK' | ||
| # pod 'Reveal-SDK' |
There was a problem hiding this comment.
Looks unused, and was causing issue (I think due to new Xcode settings around sandboxing).
| private lazy var session: AVCaptureSession = { | ||
| backgroundExecutionQueue.sync { | ||
| .init() | ||
| } | ||
| }() |
There was a problem hiding this comment.
it should be let, not lazy?
| import Foundation | ||
| import AVFoundation | ||
|
|
||
| public protocol OutputNodeType: AnyObject { |
There was a problem hiding this comment.
I thought it should be keep because AnyObject means this protocol requires as reference type. what do you think?
@ntnmrndn
There was a problem hiding this comment.
I see. No issue leaving it, I reverted it
2 participants
No description provided.