Conversation
Contributor
Contributor
|
spetrov
approved these changes
Mar 17, 2026
spetrov
left a comment
spetrov
left a comment
There was a problem hiding this comment.
LGTM! 👍🏻
It looks to me that the committed docs intentional, right?
Maybe I'm missing something, but on the other hand the pipeline is generating the docs as well...
Contributor
Author
|
Good catch. I had kept it there while validating the docs review flow, but with the PR preview in place it no longer makes sense to keep it. I’ll clean that up.
|
| s.version = package["version"] | ||
| s.summary = package["description"] | ||
| s.homepage = package["homepage"] | ||
| s.license = { :type => 'MIT', :file => 'LICENSE' } |
Contributor
There was a problem hiding this comment.
just fyi i have changes coming for all podspecs in my E2E branch
… junit reporter templates
…c, fix logger return type, and update clean-install script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR strengthens CI validation for the React Native Ping SDK by adding Android/iOS unit test workflows, standardizing affected-range handling in reusable workflows, enabling package-level iOS test execution from the sample app, and improving test reporting visibility in GitHub checks.
What Changed