Pin optional DVN count config#142
Open
dhruvinparikh wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates FixDVNs ops tooling to support a “set-config-only” generation mode, improve RPC resiliency with per-chain overrides + fallback lists, and redirect outputs to configurable generated directories.
Changes:
- Add argument parsing + modes (
set-config-only,fresh, route resume, per-chain RPC override) to the confirmation msig generator script. - Add RPC candidate selection with retry attempts across multiple RPCs.
- Update JS + Solidity scripts to honor
FIX_DVNS_GENERATED_DIRand align ULN config encoding with “nil/disabled optional DVNs”.
Reviewed changes
Copilot reviewed 3 out of 62 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/ops/fix/FixDVNs/run-op-confirmation-msigs.sh | Adds mode/arg parsing, “fresh” cleanup, multi-RPC retry strategy, and passes generated dir into Forge scripts. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779217837-2d_FixDVNsMovementAptos-252-to-33333333.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779216999-2d_FixDVNsMovementAptos-252-to-22222222.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779216275-2c_FixDVNsSolana-1-to-111111111.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779215378-2a_FixDVNsEVM-747474-to-252.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779213045-2a_FixDVNsEVM-34443-to-252.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779212297-2a_FixDVNsEVM-8453-to-252.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779212240-2a_FixDVNsEVM-5031-to-252.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779210914-2a_FixDVNsEVM-988-to-252.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779207701-2a_FixDVNsEVM-252-to-747474.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779206925-2a_FixDVNsEVM-252-to-5031.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779201507-2a_FixDVNsEVM-137-to-252.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779197753-2a_FixDVNsEVM-10-to-252.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generated/canary-nethermind-set-config-only/evm/1779194087-2a_FixDVNsEVM-1-to-252.json | Adds generated Safe batch JSON for set-config-only output. |
| scripts/ops/fix/FixDVNs/generate-zk-manual-batches.js | Adds configurable output dir + set-config-only support; updates ULN encoding for nil optional DVNs. |
| scripts/ops/fix/FixDVNs/FixDVNsInherited.s.sol | Makes generated output directory configurable via FIX_DVNS_GENERATED_DIR. |
| scripts/DeployFraxOFTProtocol/inherited/SetDVNs.s.sol | Updates DVN config comparison + sets “nil optional DVNs” fields; formatting cleanups. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+20
to
+24
| string memory generatedDir = vm.envOr( | ||
| "FIX_DVNS_GENERATED_DIR", | ||
| string("scripts/ops/fix/FixDVNs/generated/canary-nethermind") | ||
| ); | ||
| root = string.concat(root, "/", generatedDir, "/evm/"); |
| desiredUlnConfig.requiredDVNCount = uint8(desiredDVNs.length); | ||
| desiredUlnConfig.optionalDVNCount = NIL_DVN_COUNT; | ||
| desiredUlnConfig.optionalDVNThreshold = 0; | ||
| desiredUlnConfig.requiredDVNs = desiredDVNs; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.