Sketcher: OffsetInSketcher - Add BSpline and external geometry support - #219
Open
gbulleryahen-hash wants to merge 1 commit into
Open
Sketcher: OffsetInSketcher - Add BSpline and external geometry support#219gbulleryahen-hash wants to merge 1 commit into
gbulleryahen-hash wants to merge 1 commit into
Conversation
## OffsetInSketcher - v2.0 Extended version of the existing `OffsetInSketcher` macro with the following additions: ### New features - **BSpline support** : offset is computed via the Part API (`makeOffset2D`), the same method used by the CAM/Path workbench - **External geometry support** : works with edges projected from other bodies/features (`ExternalEdge`), retrieved via `ActiveSketch.ExternalGeometry` - **Corner style choice** : dialog now offers two options: - Sharp corner (Miter) - Rounded corner (Arc) ### Technical notes - All geometry (normal and external) is transformed into the sketch's local coordinate system before offset computation, ensuring correct results regardless of sketch orientation in 3D space - Single unified code path via `wire.makeOffset2D()` for all geometry types - Tested on FreeCAD 1.x ### Compatibility - Requires FreeCAD >= 0.19 - License: LGPL-2.0-or-later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OffsetInSketcher - v2.0
Extended version of the existing
OffsetInSketchermacro with the following additions:New features
makeOffset2D), the same method used by the CAM/Path workbenchExternalEdge), retrieved viaActiveSketch.ExternalGeometryTechnical notes
wire.makeOffset2D()for all geometry typesCompatibility
sharp corner:
Rounded corner
[MacroName] Short description.And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.