TCP support#112
Open
jake-scott wants to merge 2 commits into
Open
Conversation
Open
The old versions did not support Linux/ARM
094d816 to
2567e4d
Compare
Refactor networking to properly support TCP and import strlcat.
2567e4d to
e34b472
Compare
Author
|
Note another PR : #110 We took slightly different approaches. I ended up re-factoring some of the code to avoid lots of 'if tcp' blocks and cleaned up the error reporting code in the parts that I touched. I did not support per-server TCP though this is doable. I did implement separate connect/request timeouts though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First stab at TCP support in pam_radius (#102).
To enable, add
use_tcpto the PAM options.To support separate connect vs read timeouts, the timeout parameter in the config now supports two integers, comma separated. The first is the read timeout and the second optional value is the connect timeout.
This needs eyes as there was a reasonable amount of refactoring to make this work, plus it needs testing on Solaris.