Skip to content

TCP support#112

Open
jake-scott wants to merge 2 commits into
FreeRADIUS:masterfrom
jake-scott:jake/tcp-support
Open

TCP support#112
jake-scott wants to merge 2 commits into
FreeRADIUS:masterfrom
jake-scott:jake/tcp-support

Conversation

@jake-scott

@jake-scott jake-scott commented Feb 20, 2025

Copy link
Copy Markdown

First stab at TCP support in pam_radius (#102).

To enable, add use_tcp to the PAM options.

To support separate connect vs read timeouts, the timeout parameter in the config now supports two integers, comma separated. The first is the read timeout and the second optional value is the connect timeout.

This needs eyes as there was a reasonable amount of refactoring to make this work, plus it needs testing on Solaris.

@jake-scott jake-scott marked this pull request as draft February 20, 2025 19:10
@jake-scott jake-scott mentioned this pull request Feb 20, 2025
The old versions did not support Linux/ARM
Refactor networking to properly support TCP
and import strlcat.
@jake-scott

Copy link
Copy Markdown
Author

Note another PR : #110

We took slightly different approaches. I ended up re-factoring some of the code to avoid lots of 'if tcp' blocks and cleaned up the error reporting code in the parts that I touched. I did not support per-server TCP though this is doable. I did implement separate connect/request timeouts though.

@jake-scott jake-scott marked this pull request as ready for review March 4, 2025 22:18
@jake-scott jake-scott changed the title DRAFT: TCP support TCP support Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants