add environment variable attribute Framed-IPv6-Prefix when present#87
Open
DimitriPapadopoulos wants to merge 3 commits into
Open
add environment variable attribute Framed-IPv6-Prefix when present#87DimitriPapadopoulos wants to merge 3 commits into
DimitriPapadopoulos wants to merge 3 commits into
Conversation
DimitriPapadopoulos
force-pushed
the
Framed-IPv6-Prefix
branch
3 times, most recently
from
79db8f2 to
c35be53
Compare
DimitriPapadopoulos
force-pushed
the
Framed-IPv6-Prefix
branch
from
a1bddc5 to
bedf857
Compare
The current code implies `int` is 4 bytes - which it is on current Linux
platforms - and that `attr_fip->data` is aligned - which I presume it is.
Neverthless, it might be clearer to use memcpy() here.
From the Linux header <linux/in.h> :
/* Internet address. */
struct in_addr {
__be32 s_addr;
};
DimitriPapadopoulos
force-pushed
the
Framed-IPv6-Prefix
branch
from
bedf857 to
e093685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86 (comment).