Skip to content

Feat: see all performance settings / toggle done settings #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zukucker wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Feat: see all performance settings / toggle done settings #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7906b9c
feat: added new snippet for done
zukucker Jan 15, 2026
4a668a9
feat: added return SettingsResult:ok to performancechecks
zukucker Jan 15, 2026
80d8563
feat: added option to select if done is visible or not
zukucker Jan 15, 2026
13e068a
fix: wrong state
zukucker Jan 15, 2026
03a195a
fix: coding style
zukucker Jan 15, 2026
addc36a
fix: wrong types
zukucker Jan 15, 2026
f1b8811
added new static method for creating a settingsresult
zukucker Jan 26, 2026
bb0c389
refactor the if else clauses
zukucker Jan 26, 2026
0479eb0
bigger refactor
zukucker Jan 26, 2026
c996914
fix cs
zukucker Jan 26, 2026
fe07e96
fix: address performance settings review
shyim Jul 2, 2026
a3a0f29
Merge branch 'main' into feat/see-all-settings
shyim Jul 18, 2026
8694fc1
fix: address review findings
shyim Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/Components/Health/Checker/PerformanceChecker/AdminWorkerChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,14 @@ public function __construct(

public function collect(HealthCollection $collection): void
{
if ($this->adminWorkerEnabled) {
$collection->add(
SettingsResult::warning(
'admin-watcher',
'Admin-Worker',
'enabled',
'disabled',
),
);
}
$collection->add(
SettingsResult::create(
$this->adminWorkerEnabled ? SettingsResult::WARNING : SettingsResult::GREEN,
'admin-watcher',
'Admin-Worker',
$this->adminWorkerEnabled ? 'enabled' : 'disabled',
'disabled',
),
);
}
}
19 changes: 9 additions & 10 deletions src/Components/Health/Checker/PerformanceChecker/DisableAppUrlExternalCheckChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,14 @@ class DisableAppUrlExternalCheckChecker implements PerformanceCheckerInterface,
public function collect(HealthCollection $collection): void
{
$appUrlCheckDisabled = (bool) EnvironmentHelper::getVariable('APP_URL_CHECK_DISABLED', false);
if (!$appUrlCheckDisabled) {
$collection->add(
SettingsResult::warning(
'app-url-check-disabled',
'App URL external check',
'enabled',
'disabled',
),
);
}
$collection->add(
SettingsResult::create(
!$appUrlCheckDisabled ? SettingsResult::WARNING : SettingsResult::GREEN,
'app-url-check-disabled',
'App URL external check',
!$appUrlCheckDisabled ? 'enabled' : 'disabled',
'disabled',
)
);
}
}
19 changes: 9 additions & 10 deletions src/Components/Health/Checker/PerformanceChecker/DisableSymfonySecretsChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,14 @@ public function __construct(

public function collect(HealthCollection $collection): void
{
if ($this->vault) {
$collection->add(
SettingsResult::info(
'symfony-secrets',
'Disable Symfony Secrets',
'enabled',
'disabled',
),
);
}
$collection->add(
SettingsResult::create(
$this->vault ? SettingsResult::INFO : SettingsResult::GREEN,
'symfony-secrets',
'Disable Symfony Secrets',
$this->vault ? 'enabled' : 'disabled',
'disabled',
),
);
}
}
16 changes: 9 additions & 7 deletions src/Components/Health/Checker/PerformanceChecker/DisabledMailUpdatesChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@ public function collect(HealthCollection $collection): void

$setting = $this->params->get('shopware.mail.update_mail_variables_on_send');

if (!$setting) {
return;
}

$result = SettingsResult::warning('mail_variables', 'MailVariables updates', 'enabled', 'disabled');

$collection->add($result);
$collection->add(
SettingsResult::create(
!$setting ? SettingsResult::GREEN : SettingsResult::WARNING,
'mail_variables',
'MailVariables updates',
$setting ? 'enabled' : 'disabled',
'disabled'
)
);
}
}
19 changes: 9 additions & 10 deletions src/Components/Health/Checker/PerformanceChecker/EsChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,14 @@ public function __construct(ElasticsearchManager $elasticsearchManager)

public function collect(HealthCollection $collection): void
{
if (!$this->esEnabled) {
$collection->add(
SettingsResult::info(
'elasticsearch',
'Elasticsearch',
'disabled',
'enabled',
),
);
}
$collection->add(
SettingsResult::create(
!$this->esEnabled ? SettingsResult::INFO : SettingsResult::GREEN,
'elasticsearch',
'Elasticsearch',
!$this->esEnabled ? 'disabled' : 'enabled',
'enabled',
)
);
}
}
22 changes: 11 additions & 11 deletions src/Components/Health/Checker/PerformanceChecker/FineGrainedCachingChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,17 @@ public function collect(HealthCollection $collection): void
if (\version_compare($this->shopwareVersion, '6.7.0.0', '>=')) {
return;
}
$fineGrainedCachingEnabled = $this->cacheTaggingEachConfig || $this->cacheTaggingEachSnippet || $this->cacheTaggingEachThemeConfig;

if ($this->cacheTaggingEachConfig || $this->cacheTaggingEachSnippet || $this->cacheTaggingEachThemeConfig) {
$collection->add(
// only info, because it only affects redis, varnish etc.
SettingsResult::info(
'fine-grained-caching',
'Fine-grained caching on Redis, Varnish etc.',
'enabled',
'disabled',
),
);
}
$collection->add(
// only info, because it only affects redis, varnish etc.
SettingsResult::create(
$fineGrainedCachingEnabled ? SettingsResult::INFO : SettingsResult::GREEN,
'fine-grained-caching',
'Fine-grained caching on Redis, Varnish etc.',
$fineGrainedCachingEnabled ? 'enabled' : 'disabled',
'disabled',
),
);
}
}
19 changes: 9 additions & 10 deletions src/Components/Health/Checker/PerformanceChecker/FixCacheIdSetChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,14 @@ public function collect(HealthCollection $collection): void

$cacheId = (string) EnvironmentHelper::getVariable('SHOPWARE_CACHE_ID', '');

if ($cacheId === '') {
$collection->add(
SettingsResult::warning(
'cache-id',
'Fixed cache id',
'not set',
'set',
),
);
}
$collection->add(
SettingsResult::create(
$cacheId === '' ? SettingsResult::WARNING : SettingsResult::GREEN,
'cache-id',
'Fixed cache id',
$cacheId === '' ? 'not set' : 'set',
'set',
),
);
}
}
24 changes: 13 additions & 11 deletions src/Components/Health/Checker/PerformanceChecker/IncrementStorageChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,19 @@ public function __construct(

public function collect(HealthCollection $collection): void
{
$recommended = 'array or redis';
$usesMysql = $this->userActivity === 'mysql' || $this->queueActivity === 'mysql';
$current = $this->userActivity === $this->queueActivity
? $this->userActivity
: $this->userActivity . ', ' . $this->queueActivity;

if ($this->userActivity === 'mysql' || $this->queueActivity === 'mysql') {
$collection->add(
SettingsResult::warning(
'increment-storage',
'Increment storage',
'mysql',
$recommended,
),
);
}
$collection->add(
SettingsResult::create(
$usesMysql ? SettingsResult::WARNING : SettingsResult::GREEN,
'increment-storage',
'Increment storage',
$current,
'array or redis',
),
);
}
}
9 changes: 5 additions & 4 deletions src/Components/Health/Checker/PerformanceChecker/LoggerLevelChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,14 @@ public function __construct(

public function collect(HealthCollection $collection): void
{
if ($this->businessEventHandlerLevel->isLowerThan(Level::Warning)) {
$collection->add(SettingsResult::warning(
$collection->add(
SettingsResult::create(
$this->businessEventHandlerLevel->isLowerThan(Level::Warning) ? SettingsResult::WARNING : SettingsResult::GREEN,
'business_logger',
'BusinessEventHandler logging',
Logger::toMonologLevel($this->businessEventHandlerLevel)->getName(),
'min WARNING',
));
}
),
);
}
}
19 changes: 9 additions & 10 deletions src/Components/Health/Checker/PerformanceChecker/MailOverQueueChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,14 @@ public function __construct(

public function collect(HealthCollection $collection): void
{
if (!$this->mailerIsOverQueue) {
$collection->add(
SettingsResult::warning(
'mail',
'Sending mails over queue',
'disabled',
'enabled',
),
);
}
$collection->add(
SettingsResult::create(
!$this->mailerIsOverQueue ? SettingsResult::WARNING : SettingsResult::GREEN,
'mail',
'Sending mails over queue',
$this->mailerIsOverQueue ? 'enabled' : 'disabled',
'enabled',
),
);
}
}
21 changes: 11 additions & 10 deletions src/Components/Health/Checker/PerformanceChecker/MessengerAutoSetupChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,17 @@ public function __construct(

public function collect(HealthCollection $collection): void
{
if ($this->isAutoSetupEnabled($this->messageTransportDsn) || $this->isAutoSetupEnabled($this->messageTransportDsnLowPriority) || $this->isAutoSetupEnabled($this->messageTransportDsnFailure)) {
$collection->add(
SettingsResult::info(
'messenger-auto-setup',
'Messenger auto_setup',
'enabled',
'disabled',
),
);
}
$autoSetupState = $this->isAutoSetupEnabled($this->messageTransportDsn) || $this->isAutoSetupEnabled($this->messageTransportDsnLowPriority) || $this->isAutoSetupEnabled($this->messageTransportDsnFailure);

$collection->add(
SettingsResult::create(
$autoSetupState ? SettingsResult::INFO : SettingsResult::GREEN,
'messenger-auto-setup',
'Messenger auto_setup',
$autoSetupState ? 'enabled' : 'disabled',
'disabled',
),
);
}

private function isAutoSetupEnabled(string $messageTransportDsn): bool
Expand Down
87 changes: 49 additions & 38 deletions src/Components/Health/Checker/PerformanceChecker/MysqlSettingsChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,46 +41,57 @@ private function checkGroupConcatMaxLen(HealthCollection $collection): void
{
/** @var string|false $groupConcatMaxLen */
$groupConcatMaxLen = $this->connection->fetchOne('SELECT @@group_concat_max_len');
if (!$groupConcatMaxLen || (int) $groupConcatMaxLen < self::MYSQL_GROUP_CONCAT_MAX_LEN) {
$collection->add(
SettingsResult::error(
'sql_group_concat_max_len',
'MySQL value group_concat_max_len',
(string) $groupConcatMaxLen,
'min ' . self::MYSQL_GROUP_CONCAT_MAX_LEN,
),
);
}
$maxLenNotOk = (int) $groupConcatMaxLen < self::MYSQL_GROUP_CONCAT_MAX_LEN;

$collection->add(
SettingsResult::create(
$maxLenNotOk ? SettingsResult::ERROR : SettingsResult::GREEN,
'sql_group_concat_max_len',
'MySQL value group_concat_max_len',
(string) $groupConcatMaxLen,
'min ' . self::MYSQL_GROUP_CONCAT_MAX_LEN,
),
);
}

private function checkSqlMode(HealthCollection $collection): void
{
$sqlMode = $this->connection->fetchOne('SELECT @@sql_mode');
if (\is_string($sqlMode) && \str_contains($sqlMode, self::MYSQL_SQL_MODE_PART)) {
$collection->add(
SettingsResult::error(
'sql_mode',
'MySQL value sql_mode',
$sqlMode,
'No ' . self::MYSQL_SQL_MODE_PART,
),
);

if (!\is_string($sqlMode)) {
return;
}

$hasForbiddenMode = \str_contains($sqlMode, self::MYSQL_SQL_MODE_PART);
$collection->add(
SettingsResult::create(
$hasForbiddenMode ? SettingsResult::ERROR : SettingsResult::GREEN,
'sql_mode',
'MySQL value sql_mode',
$sqlMode,
'No ' . self::MYSQL_SQL_MODE_PART,
),
);
}

private function checkTimeZone(HealthCollection $collection): void
{
$timeZone = $this->connection->fetchOne('SELECT @@time_zone');
if (\is_string($timeZone) && !\in_array($timeZone, self::MYSQL_TIME_ZONES, true)) {
$collection->add(
SettingsResult::warning(
'sql_time_zone',
'MySQL value time_zone',
$timeZone,
implode(', ', self::MYSQL_TIME_ZONES),
),
);

if (!\is_string($timeZone)) {
return;
}

$isInvalidTimeZone = !\in_array($timeZone, self::MYSQL_TIME_ZONES, true);
$collection->add(
SettingsResult::create(
$isInvalidTimeZone ? SettingsResult::WARNING : SettingsResult::GREEN,
'sql_time_zone',
'MySQL value time_zone',
$timeZone,
implode(', ', self::MYSQL_TIME_ZONES),
),
);
}

private function checkCheckDefaultEnvironmentSessionVariables(HealthCollection $collection): void
Expand All @@ -91,15 +102,15 @@ private function checkCheckDefaultEnvironmentSessionVariables(HealthCollection $
}

$setSessionVariables = (bool) EnvironmentHelper::getVariable('SQL_SET_DEFAULT_SESSION_VARIABLES', true);
if ($setSessionVariables) {
$collection->add(
SettingsResult::warning(
'sql_set_default_session_variables',
'MySQL session vars are set on each connect',
'enabled',
'disabled',
),
);
}

$collection->add(
SettingsResult::create(
$setSessionVariables ? SettingsResult::WARNING : SettingsResult::GREEN,
'sql_set_default_session_variables',
'MySQL session vars are set on each connect',
$setSessionVariables ? 'enabled' : 'disabled',
'disabled',
),
);
}
}
Loading
Loading