Build review-detail media URL from the request instead of a settings value#1937
Merged
Conversation
…value Avoids depending on a SITE_URL setting that must be kept in sync with the actual deployment domain; request.build_absolute_uri() reflects whatever host the request actually arrived on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review_detailendpoint was building its media base URL from aSITE_URLsetting that must be manually kept in sync with the actual deployment domain, and had no such setting defined for this deployment.request.build_absolute_uri(settings.MEDIA_URL)instead, which reflects whatever host the request actually arrived on.Test plan