feat: Bump to C++20 and update TPLs - #4127
Open
victorapm wants to merge 23 commits into
Open
Conversation
victorapm
added
the
ci: run integrated tests
victorapm
requested review from
frankfeifan,
jafranc,
jhuang2601,
joshua-white,
kimtaeho07 and
tjb-ltk
as code owners
August 21, 2026 03:05
victorapm
added
the
ci: run device builds
victorapm
requested review from
acitrain,
cssherman and
sframba
as code owners
August 21, 2026 10:13
dkachuma
approved these changes
Aug 21, 2026
| #include "../include/fmt/ranges.h" | ||
| #include "../include/fmt/xchar.h" | ||
| #define GEOS_FMT_NS fmt | ||
| #else // use C++20's <format> |
Contributor
There was a problem hiding this comment.
I'm a bit confused here. Since we are not enforcing C++20, shouldn't we always use <format>?
Contributor
Author
There was a problem hiding this comment.
Hi Dick, this branch is enforcing C++20, but {fmt} remains intentional because GEOS uses fmt::runtime, fmt::join, fmt::is_formattable and custom fmt::formatter. Also, <format> is not uniformly supported by the CUDA/HIP backends. Maybe we can address this on a separate PR
victorapm
added
the
flag: requires rebaseline
Contributor
Author
|
Rebaseline needed because of a baseline mismatch (3051 vs 3095 faces) caused by the VTK 9.4.2 → 9.7.0 upgrade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on GEOS-DEV/thirdPartyLibs#361
Depends on GEOS-DEV/LvArray#356