Conversation
craigpnnl
approved these changes
Sep 16, 2024
| __pycache__/ | ||
| *.py[cod] | ||
| *$py.class | ||
| .vscode/ |
Contributor
There was a problem hiding this comment.
Remove conversion_dict_master* it's referenced as measurement dict in the main
| 'conversion_type'] | ||
| object_name=device_ip_port_dict['CIM object'] | ||
|
|
||
Contributor
There was a problem hiding this comment.
The master_pnnl.py-old file should not be here.
craigpnnl
reviewed
Sep 16, 2024
| if mrid not in CIM_msg: | ||
| CIM_msg[mrid] = CIM_value | ||
| CIM_msg[mrid][CIM_attribute] = value * multiplier # times multipier | ||
| #def update_cim_msg_analog_multi_index(self, CIM_msg, index, value, conversion, model): |
Contributor
There was a problem hiding this comment.
If this needs to be removed then remove rather than comment out.
craigpnnl
requested changes
Sep 16, 2024
| { | ||
| "s102c": { | ||
| "VA": { | ||
| "C": { |
Contributor
There was a problem hiding this comment.
This file snold not have been added --old?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated DNP3 libraries to be compatible with python version 3.10 and above.