PlugLayout : "layout:accessory" fixes#6829
Open
murraystevenson wants to merge 2 commits intoGafferHQ:1.6_maintenancefrom
Open
PlugLayout : "layout:accessory" fixes#6829murraystevenson wants to merge 2 commits intoGafferHQ:1.6_maintenancefrom
murraystevenson wants to merge 2 commits intoGafferHQ:1.6_maintenancefrom
Conversation
Otherwise a plug with "accessory" metadata following a plug with "divider" metadata resulted in the Divider and the accessory plug being put into an _AccessoryRow below the primary plug. This change groups the primary plug and its accessory in an _AccessoryRow, with the Divider below. Dividers aren't deduplicated, so if both the primary plug and the accessory have divider metadata, two Dividers will be created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple of bugs that I'd say are prerequisites before we consider implementing #6523. The first seems a legit bug worth fixing. The second commit is technically a change in behaviour if anyone is relying on divider-button rows, so could be shuffled off to
mainif that's a better place for it, or dropped altogether if we consider the existing behaviour reasonable...