Skip to content

[GFX-639] 消除 FlagOptionAttributeTests 的 Sonar S2701 字面量布尔断言 #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlianBlank merged 1 commit into from
Aug 12, 2026
Merged

[GFX-639] 消除 FlagOptionAttributeTests 的 Sonar S2701 字面量布尔断言 #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions GameFrameX.Foundation.Tests/Options/FlagOptionAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,31 +21,31 @@ public class FlagOptionAttributeTests
public void DefaultConstructor_ShouldSetDefaultValueToFalse()
{
var attr = new FlagOptionAttribute();
Assert.Equal(false, attr.DefaultValue);
Assert.False((bool)attr.DefaultValue);
}

[Fact]
public void ConstructorWithLongName_ShouldSetLongNameAndDefaultValueToFalse()
{
var attr = new FlagOptionAttribute("verbose");
Assert.Equal("verbose", attr.LongName);
Assert.Equal(false, attr.DefaultValue);
Assert.False((bool)attr.DefaultValue);
}

[Fact]
public void ConstructorWithNullLongName_ShouldSetNullLongNameAndDefaultValueToFalse()
{
var attr = new FlagOptionAttribute(null);
Assert.Null(attr.LongName);
Assert.Equal(false, attr.DefaultValue);
Assert.False((bool)attr.DefaultValue);
}

[Fact]
public void ConstructorWithEmptyLongName_ShouldSetEmptyLongName()
{
var attr = new FlagOptionAttribute("");
Assert.Equal("", attr.LongName);
Assert.Equal(false, attr.DefaultValue);
Assert.False((bool)attr.DefaultValue);
}

// ============================================================
Expand Down Expand Up @@ -73,7 +73,7 @@ public void FlagOptionAttribute_ShouldAccessInheritedProperties()
Assert.Equal("Enable debug mode", attr.Description);
Assert.Equal("DEBUG_FLAG", attr.EnvironmentVariable);
Assert.False(attr.Sensitive);
Assert.Equal(false, attr.DefaultValue);
Assert.False((bool)attr.DefaultValue);
}

// ============================================================
Expand Down