Skip to content

[GFX-548] 移除 KcpServer._onDisconnected 未读字段以消除 Sonar S4487 - #365

Merged
github-actions[bot] merged 2 commits into
mainfrom
feature/auto-server-source-worker-run-1165-20260806T1620
Aug 7, 2026
Merged

[GFX-548] 移除 KcpServer._onDisconnected 未读字段以消除 Sonar S4487#365
github-actions[bot] merged 2 commits into
mainfrom
feature/auto-server-source-worker-run-1165-20260806T1620

Conversation

@AlianBlank

@AlianBlank AlianBlank commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Linear: GFX-548

Summary by CodeRabbit

  • 重构
    • 移除了服务器内部未使用的断开连接回调保存逻辑。
    • 不影响现有对外功能或公共接口。

@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

GFX-548

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d2c44f0d-767a-4c2c-825a-9ee12f1a08d0

📥 Commits

Reviewing files that changed from the base of the PR and between 1fc9055 and 3a28ca5.

📒 Files selected for processing (1)
  • GameFrameX.NetWork.Kcp/KcpServer.cs
💤 Files with no reviewable changes (1)
  • GameFrameX.NetWork.Kcp/KcpServer.cs

📝 Walkthrough

Walkthrough

KcpServer 仍接收 onDisconnected 构造参数,但不再保存该回调。相关私有字段和构造函数赋值已移除。

Changes

KcpServer 回调清理

Layer / File(s) Summary
移除断开回调存储
GameFrameX.NetWork.Kcp/KcpServer.cs
删除 _onDisconnected 私有字段,并移除构造函数中的赋值。构造函数签名未改变。

Estimated code review effort: 1 (简单) | ~5 分钟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确说明移除 KcpServer._onDisconnected 未读字段及其 Sonar S4487 修复目标,与变更内容和 PR 目标一致。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/auto-server-source-worker-run-1165-20260806T1620

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot merged commit 3d9fa5b into main Aug 7, 2026
2 of 3 checks passed
@github-actions
github-actions Bot deleted the feature/auto-server-source-worker-run-1165-20260806T1620 branch August 7, 2026 07:54
@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant