Skip to content

[GFX-549] 抽取 ConfigureLogOptions 的 GrafanaLoki 标签收集逻辑为 private 辅助方法消除 Sonar S3776 - #366

Merged
github-actions[bot] merged 2 commits into
mainfrom
feature/gfx-549
Aug 7, 2026
Merged

[GFX-549] 抽取 ConfigureLogOptions 的 GrafanaLoki 标签收集逻辑为 private 辅助方法消除 Sonar S3776#366
github-actions[bot] merged 2 commits into
mainfrom
feature/gfx-549

Conversation

@AlianBlank

@AlianBlank AlianBlank commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Linear: GFX-549

Summary by CodeRabbit

  • 改进
    • 优化 Grafana Loki 日志标签的收集与写入流程。
    • 保持现有标签过滤、空值处理和重复标签告警行为,提升日志记录的一致性与稳定性。

@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

GFX-549

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 399024f7-3ac4-4d9f-ada6-f296a968cc15

📥 Commits

Reviewing files that changed from the base of the PR and between 405f74c and df8cbc6.

📒 Files selected for processing (1)
  • GameFrameX.AppHost/Program.cs

📝 Walkthrough

Walkthrough

将 Grafana Loki 标签收集逻辑从 ConfigureLogOptions 提取到新的 ApplyGrafanaLokiLabels 私有方法中,并保留原有处理规则。

Changes

Grafana Loki 标签处理

Layer / File(s) Summary
提取标签收集逻辑
GameFrameX.AppHost/Program.cs
ConfigureLogOptions 调用 ApplyGrafanaLokiLabels。新方法通过反射收集有效标签,并保留属性过滤、ServerType 排除、空值跳过、重复标签告警和标签写入行为。

Estimated code review effort: 2 (简单) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/gfx-549

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot merged commit 9a1b815 into main Aug 7, 2026
1 of 3 checks passed
@github-actions
github-actions Bot deleted the feature/gfx-549 branch August 7, 2026 01:43
@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant