Skip to content

[GFX-589] 删除 HealthTracker 未读字段 LastFailureTick 消除 Sonar S4487 - #367

Merged
github-actions[bot] merged 2 commits into
mainfrom
feature/auto-server-source-worker-run-1167-20260806T1640
Aug 7, 2026
Merged

[GFX-589] 删除 HealthTracker 未读字段 LastFailureTick 消除 Sonar S4487#367
github-actions[bot] merged 2 commits into
mainfrom
feature/auto-server-source-worker-run-1167-20260806T1640

Conversation

@AlianBlank

@AlianBlank AlianBlank commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Linear: GFX-589

Summary by CodeRabbit

  • 改进
    • 优化端点健康状态记录,移除不再使用的失败时间信息。
    • 端点健康评分及状态更新行为保持不变。

@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

GFX-589

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 32c22cf6-bd2c-4dd5-b491-6d0af5cf98b3

📥 Commits

Reviewing files that changed from the base of the PR and between 1fc9055 and 2bc41ef.

📒 Files selected for processing (1)
  • GameFrameX.NetWork.RemoteMessaging/Resilience/DefaultEndpointHealthEvaluator.cs
💤 Files with no reviewable changes (1)
  • GameFrameX.NetWork.RemoteMessaging/Resilience/DefaultEndpointHealthEvaluator.cs

📝 Walkthrough

Walkthrough

DefaultEndpointHealthEvaluator 不再记录端点最近失败时间。MarkUnavailable 仍递增连续失败次数。HealthTracker 仅保留失败计数和最近成功时间。

Changes

端点健康跟踪

Layer / File(s) Summary
移除失败时间记录
GameFrameX.NetWork.RemoteMessaging/Resilience/DefaultEndpointHealthEvaluator.cs
MarkUnavailable 移除 LastFailureTick 赋值。私有嵌套类 HealthTracker 移除 LastFailureTick 字段。连续失败次数逻辑保持不变。

Estimated code review effort: 1 (简单) | ~5 分钟

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确说明删除未读字段 LastFailureTick,并指出其目的为消除 Sonar S4487 告警。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/auto-server-source-worker-run-1167-20260806T1640

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot merged commit 4ae1c41 into main Aug 7, 2026
1 of 2 checks passed
@github-actions
github-actions Bot deleted the feature/auto-server-source-worker-run-1167-20260806T1640 branch August 7, 2026 01:43
@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant