Publish continuous release and run reccmp diff in CI#52
Open
disinvite wants to merge 1 commit intoGensokyoClub:mainfrom
Open
Publish continuous release and run reccmp diff in CI#52disinvite wants to merge 1 commit intoGensokyoClub:mainfrom
disinvite wants to merge 1 commit intoGensokyoClub:mainfrom
Conversation
xmvziron
reviewed
Apr 15, 2026
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| ./upload.sh \ | ||
| build-dll/* \ |
Collaborator
There was a problem hiding this comment.
Forgive my ignorance, but doesn't this update all the files in the build-dll/ folder? Even the obj files that aren't needed?
Author
There was a problem hiding this comment.
It should only be the artifact files uploaded from the build and build-dll steps:
# upload:
- uses: actions/upload-artifact@v4
with:
name: th08
path: |
build/th08.exe
build/th08.pdb
# download:
- uses: actions/download-artifact@main
with:
name: th08
path: build
# upload:
- uses: actions/upload-artifact@v4
with:
name: th08-dll
path: |
build/th08.dll
build/th08.pdb
# download:
- uses: actions/download-artifact@main
with:
name: th08-dll
path: build-dllbut we can change it on the final release action to make that more clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the reccmp steps into the build pipeline. The
reccmp-reccmp --json <file>command creates a file to be used later byreccmp-reccmp --diff <file>to display the diff report for the pull request or push.To do this, the JSON file of the last push to master needs to exist somewhere. We package that and the build artifacts into a continuous release. This is the same workflow we used in isledecomp/isle.
I could not test the release step on my branch. Hopefully all the paths are correct.