Skip to content

Publish continuous release and run reccmp diff in CI#52

Open
disinvite wants to merge 1 commit intoGensokyoClub:mainfrom
disinvite:ci-release
Open

Publish continuous release and run reccmp diff in CI#52
disinvite wants to merge 1 commit intoGensokyoClub:mainfrom
disinvite:ci-release

Conversation

@disinvite
Copy link
Copy Markdown

I moved the reccmp steps into the build pipeline. The reccmp-reccmp --json <file> command creates a file to be used later by reccmp-reccmp --diff <file> to display the diff report for the pull request or push.

To do this, the JSON file of the last push to master needs to exist somewhere. We package that and the build artifacts into a continuous release. This is the same workflow we used in isledecomp/isle.

I could not test the release step on my branch. Hopefully all the paths are correct.

Comment thread .github/workflows/ci.yml
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
./upload.sh \
build-dll/* \
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive my ignorance, but doesn't this update all the files in the build-dll/ folder? Even the obj files that aren't needed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should only be the artifact files uploaded from the build and build-dll steps:

# upload:
- uses: actions/upload-artifact@v4
  with:
    name: th08
    path: |
      build/th08.exe
      build/th08.pdb
# download:
- uses: actions/download-artifact@main
  with:
   name: th08
   path: build

# upload:
- uses: actions/upload-artifact@v4
  with:
    name: th08-dll
    path: |
      build/th08.dll
      build/th08.pdb
# download:
- uses: actions/download-artifact@main
  with:
   name: th08-dll
   path: build-dll

but we can change it on the final release action to make that more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants