Skip to content

Admissions: fix applicant not linked to admissions account on acceptance#2084

Open
brianp-matrix wants to merge 1 commit into
GibbonEdu:v31.0.00from
brianp-matrix:fix/admissions-applicant-linking
Open

Admissions: fix applicant not linked to admissions account on acceptance#2084
brianp-matrix wants to merge 1 commit into
GibbonEdu:v31.0.00from
brianp-matrix:fix/admissions-applicant-linking

Conversation

@brianp-matrix

@brianp-matrix brianp-matrix commented Apr 8, 2026

Copy link
Copy Markdown

Summary

  • The acceptance process in applications_manage_acceptProcess.php used hasResult()/getResult() to check for parent and family records created during acceptance
  • However, CreateParents.php and CreateFamily.php store these values using set(), not setResult() — so the condition always failed silently
  • Changed to has()/get() to match how the data is actually stored by the form builder processes

Impact: Without this fix, accepting an application creates the student, parents, and family correctly, but the admissions account's gibbonPersonID is never updated — the applicant (parent) remains unlinked.

Test plan

  • Create a new admissions application with parent details
  • Accept the application
  • Verify gibbonAdmissionsAccount.gibbonPersonID is set to the parent's person ID
  • Verify gibbonAdmissionsAccount.gibbonFamilyID is set to the new family ID

The acceptance process used hasResult()/getResult() to check for parent
and family records created during acceptance, but CreateParents.php and
CreateFamily.php store these values using set(), not setResult().

Changed to has()/get() to match how the data is actually stored by the
form builder processes. Without this fix, the admissions account's
gibbonPersonID is never updated to link the applicant (parent) to their
person record.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@SKuipers SKuipers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brianp-matrix, I appreciate you taking time to share your code as a PR. Are you able to help explain the issue you've encountered in greater detail? I've tried to reproduce it on my end and the script seems to be working as expected, with the gibbonPersonID and gibbonFamilyID fields being populated on acceptance.

The applications_manage_acceptProcess.php script runs a method called setReadOnly, which ensures that all data captured from the acceptance process goes into Results and not the original Data, this way it does not overwrite data the applicant submitted with generated data.

So, the getResult() method should be returning the correct data at that point in the code. If you're encountering an issue and not seeing the same thing on your end, let me know what steps I can take to reproduce the issue, and I'm happy to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants