fix: resolved some missing quotations#108
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small consistency improvements in the logger’s internal log-level conversion and aligns SonarQube’s configured project version with the current release version.
Changes:
- Quote
LOG_LEVEL_*variable expansions in_get_log_level_value()return paths. - Update
sonar.projectVersionfrom2.2.1to2.5.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
logging.sh |
Quotes numeric log-level constant expansions when echoing return values in _get_log_level_value(). |
sonar-project.properties |
Updates sonar.projectVersion to 2.5.0 to match the current project version. |
GingerGraham
pushed a commit
that referenced
this pull request
Apr 18, 2026
## [2.5.1](2.5.0...2.5.1) (2026-04-18) ### Bug Fixes * resolved some missing quotations ([#108](#108))
Owner
Author
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes minor improvements to the
logging.shscript and an update to the project version insonar-project.properties. The main focus is on improving code consistency and clarity.Shell script improvements:
echostatements within the_get_log_level_value()function inlogging.sh, which helps prevent potential word-splitting or globbing issues. [1] [2]Project configuration:
sonar.projectVersioninsonar-project.propertiesfrom2.2.1to2.5.0to reflect the new version.