Skip to content

docs: establish AGENTS.md as canonical agent instruction file#110

Merged
GingerGraham merged 2 commits into
mainfrom
claude/review-agent-instructions-TK8ET
Apr 21, 2026
Merged

docs: establish AGENTS.md as canonical agent instruction file#110
GingerGraham merged 2 commits into
mainfrom
claude/review-agent-instructions-TK8ET

Conversation

@GingerGraham
Copy link
Copy Markdown
Owner

AGENTS.md becomes the single source of truth for agent guidance. Both CLAUDE.md and .github/copilot-instructions.md are now symlinks pointing to it, eliminating duplicated maintenance.

Content is slimmed to a standards overview: shell compatibility, code style, Markdown rules, and a pre-PR checklist. Detailed procedural content (test patterns, commit format tables, linting commands, security checklists) is deferred to the six skills in .claude/skills/, which are loaded automatically by Claude Code, GitHub Copilot, and any agent implementing the open Agent Skills standard.

Also fixes a stale inaccuracy: the previous file listed 'refactor' as triggering no version bump; the writing-commits skill (now the source of truth) correctly documents it as a patch bump.

https://claude.ai/code/session_01BwkVcHyk7eJKBDWgyUdnhJ

AGENTS.md becomes the single source of truth for agent guidance.
Both CLAUDE.md and .github/copilot-instructions.md are now symlinks
pointing to it, eliminating duplicated maintenance.

Content is slimmed to a standards overview: shell compatibility, code
style, Markdown rules, and a pre-PR checklist. Detailed procedural
content (test patterns, commit format tables, linting commands, security
checklists) is deferred to the six skills in .claude/skills/, which are
loaded automatically by Claude Code, GitHub Copilot, and any agent
implementing the open Agent Skills standard.

Also fixes a stale inaccuracy: the previous file listed 'refactor' as
triggering no version bump; the writing-commits skill (now the source of
truth) correctly documents it as a patch bump.

https://claude.ai/code/session_01BwkVcHyk7eJKBDWgyUdnhJ
Copilot AI review requested due to automatic review settings April 21, 2026 10:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Establishes AGENTS.md as the canonical, slimmed-down agent guidance document for the bash-logger repo, delegating detailed procedures to the .claude/skills/* documents.

Changes:

  • Adds AGENTS.md with links to the six skills and a standards overview (linting, tests, commits, shell compatibility, Markdown rules, code style).
  • Documents Conventional Commits / semantic-release expectations and a pre-PR checklist for agents.

Comment thread AGENTS.md Outdated
* Use POSIX-compatible syntax whenever possible
* Use `[ ]` instead of `[[ ]]` for maximum compatibility
* Use `$(...)` instead of backticks (works everywhere)
* Use `.` or `source` for sourcing files (both POSIX)
Comment thread AGENTS.md
Comment on lines +107 to +108
* **MD060** — table separators: `| --- | --- |` with spaces, never `|---|---|`

Comment thread AGENTS.md Outdated
Comment on lines +74 to +85
* Use POSIX-compatible syntax whenever possible
* Use `[ ]` instead of `[[ ]]` for maximum compatibility
* Use `$(...)` instead of backticks (works everywhere)
* Use `.` or `source` for sourcing files (both POSIX)
* Avoid bash-specific features like arrays and associative arrays unless necessary
* Document shell requirements in comments

**DON'T:**

* Use bash-only features like `[[ ]]`, `(( ))`, or `=~` unless necessary
* Use bash arrays or associative arrays unless truly needed
* Rely on bash-specific string manipulation
@GingerGraham
Copy link
Copy Markdown
Owner Author

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026

@copilot apply changes based on the comments in this thread

Applied all three changes in commit 6046fe5:

  • source POSIX claim — updated to "Use . for POSIX sh; source is Bash/Zsh/Ksh-specific (but widely supported)"
  • [ ] vs [[ ]] guidance — DO list now says prefer [[ ]] in Bash-targeted files (like logging.sh), reserve [ ] for scripts where POSIX portability is explicitly required; DON'T list updated to "Use [[ ]], (( )), or =~ in scripts that must be POSIX-portable"
  • MD060 attribution — rather than removing it, added MD060: { style: "spaced" } to .markdownlint.yaml so the rule is now actually enforced, consistent with both AGENTS.md and the linting-code skill (which also documents MD060 as a requirement)

@GingerGraham GingerGraham merged commit c49c5b5 into main Apr 21, 2026
5 checks passed
@GingerGraham GingerGraham deleted the claude/review-agent-instructions-TK8ET branch April 21, 2026 10:29
GingerGraham pushed a commit that referenced this pull request May 27, 2026
## [2.5.2](2.5.1...2.5.2) (2026-05-27)

### Bug Fixes

* match typeset in readonly guard for zsh compatibility ([#115](#115))

### Documentation

* add claude skills for linting, pre-PR checks, running tests, se… ([#109](#109))
* establish AGENTS.md as canonical agent instruction file ([#110](#110))
@GingerGraham
Copy link
Copy Markdown
Owner Author

🎉 This PR is included in version 2.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants