Matter - Add Vacuum Cleaner #2516
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { Component } from 'preact'; | ||
| import cx from 'classnames'; | ||
| import { Text } from 'preact-i18n'; | ||
| import style from './style.css'; | ||
|
|
||
| class VacuumCleanerDockDeviceFeature extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| loading: false | ||
| }; | ||
| } | ||
|
|
||
| dock = async () => { | ||
| await this.setState({ loading: true }); | ||
| this.props.updateValue(this.props.deviceFeature, 1); | ||
| setTimeout(() => { | ||
| this.setState({ loading: false }); | ||
| }, 350); | ||
| }; | ||
|
|
||
| render(props, { loading }) { | ||
| return ( | ||
| <tr> | ||
| <td> | ||
| <i class="fe fe-home" /> | ||
| </td> | ||
| <td>{props.rowName}</td> | ||
| <td class="text-right"> | ||
| <button | ||
| onClick={this.dock} | ||
| type="button" | ||
| class={cx('btn', 'btn-outline-primary', 'btn-sm', style.btnLoading, { | ||
| 'btn-loading': loading | ||
| })} | ||
| > | ||
| <i class="fe fe-home" /> <Text id="dashboard.boxes.devicesInRoom.vacuumDock" /> | ||
| </button> | ||
| </td> | ||
| </tr> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export default VacuumCleanerDockDeviceFeature; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,43 @@ | ||||||||||||||
| import get from 'get-value'; | ||||||||||||||
| import { Text } from 'preact-i18n'; | ||||||||||||||
|
|
||||||||||||||
| import { DeviceFeatureCategoriesIcon } from '../../../../utils/consts'; | ||||||||||||||
| import { VACUUM_CLEANER_MODE } from '../../../../../../server/utils/constants'; | ||||||||||||||
|
|
||||||||||||||
| const VacuumCleanerModeDeviceFeature = ({ children, ...props }) => { | ||||||||||||||
| const { deviceFeature } = props; | ||||||||||||||
| const { category, type } = deviceFeature; | ||||||||||||||
|
|
||||||||||||||
| function updateValue(e) { | ||||||||||||||
| props.updateValueWithDebounce(deviceFeature, e.currentTarget.value); | ||||||||||||||
| } | ||||||||||||||
|
Comment on lines
+11
to
+13
There was a problem hiding this comment. Cast selected mode to number before updating value.
🔧 Proposed fix function updateValue(e) {
- props.updateValueWithDebounce(deviceFeature, e.currentTarget.value);
+ props.updateValueWithDebounce(deviceFeature, Number(e.currentTarget.value));
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| return ( | ||||||||||||||
| <tr> | ||||||||||||||
| <td> | ||||||||||||||
| <i class={`fe fe-${get(DeviceFeatureCategoriesIcon, `${category}.${type}`, { default: 'settings' })}`} /> | ||||||||||||||
| </td> | ||||||||||||||
| <td>{props.rowName}</td> | ||||||||||||||
|
|
||||||||||||||
| <td class="py-0"> | ||||||||||||||
| <div class="justify-content-end"> | ||||||||||||||
| <div class="form-group mb-0"> | ||||||||||||||
| <select value={props.deviceFeature.last_value} onChange={updateValue} class="form-control form-control-sm"> | ||||||||||||||
| <option value={VACUUM_CLEANER_MODE.IDLE}> | ||||||||||||||
| <Text id={`deviceFeatureAction.category.vacuum-cleaner.mode.idle`} /> | ||||||||||||||
| </option> | ||||||||||||||
| <option value={VACUUM_CLEANER_MODE.CLEANING}> | ||||||||||||||
| <Text id={`deviceFeatureAction.category.vacuum-cleaner.mode.cleaning`} /> | ||||||||||||||
| </option> | ||||||||||||||
| <option value={VACUUM_CLEANER_MODE.MAPPING}> | ||||||||||||||
| <Text id={`deviceFeatureAction.category.vacuum-cleaner.mode.mapping`} /> | ||||||||||||||
| </option> | ||||||||||||||
| </select> | ||||||||||||||
| </div> | ||||||||||||||
| </div> | ||||||||||||||
| </td> | ||||||||||||||
| </tr> | ||||||||||||||
| ); | ||||||||||||||
| }; | ||||||||||||||
|
|
||||||||||||||
| export default VacuumCleanerModeDeviceFeature; | ||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { Text } from 'preact-i18n'; | ||
| import cx from 'classnames'; | ||
|
|
||
| const VacuumCleanerStateDeviceValue = props => { | ||
| const { last_value: lastValue = null } = props.deviceFeature; | ||
| const valued = lastValue !== null; | ||
|
|
||
| return ( | ||
| <span | ||
| class={cx('badge', { | ||
| 'bg-primary': valued, | ||
| 'bg-secondary': !valued | ||
| })} | ||
| > | ||
| {!valued && <Text id="dashboard.boxes.devicesInRoom.noValue" />} | ||
| {valued && ( | ||
| <Text id={`deviceFeatureValue.category.vacuum-cleaner.state.${lastValue}`}> | ||
| <Text id={`deviceFeatureValue.category.vacuum-cleaner.state.unknown`} fields={{ value: lastValue }} /> | ||
| </Text> | ||
| )} | ||
| </span> | ||
| ); | ||
| }; | ||
|
|
||
| export default VacuumCleanerStateDeviceValue; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In Preact class components, doessetStatereturn a Promise that can be awaited?💡 Result:
No, in Preact class components, setState does not return a Promise that can be awaited. It returns void.
Citations:
Tie loading state to the actual command promise and prevent duplicate dock requests.
await this.setState(...)has no effect in Preact (setState returns void), and resetting loading after a fixed timeout (350ms) can re-enable clicks beforeupdateValuecompletes or fails. The button also lacks thedisabledattribute to prevent duplicate submissions during the request.Proposed fix
class VacuumCleanerDockDeviceFeature extends Component { @@ dock = async () => { - await this.setState({ loading: true }); - this.props.updateValue(this.props.deviceFeature, 1); - setTimeout(() => { - this.setState({ loading: false }); - }, 350); + if (this.state.loading) { + return; + } + this.setState({ loading: true }); + try { + await this.props.updateValue(this.props.deviceFeature, 1); + } finally { + this.setState({ loading: false }); + } }; @@ <button onClick={this.dock} type="button" + disabled={loading} class={cx('btn', 'btn-outline-primary', 'btn-sm', style.btnLoading, { 'btn-loading': loading })} >Also applies to: 30-35
🤖 Prompt for AI Agents