Conversation
enocom
force-pushed
the
telemetry
branch
4 times, most recently
from
5ac6cf3 to
c5b9ab5
Compare
Member
Author
|
I'll resolve these conflicts shortly here. |
Member
Author
|
|
enocom
force-pushed
the
telemetry
branch
4 times, most recently
from
b85e31f to
a862a83
Compare
This commit adds the OpenTelemetry-based wiring to report on internal operations to improve connectivity. To disable this internal metric collection, set enable_builtin_telemetry to False when creating a Connetor or AsyncConnector. Fixes #449
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the OpenTelemetry-based wiring to report on internal operations to improve connectivity. To disable this internal metric collection, set enable_builtin_telemetry to False when creating a Connector or AsyncConnector.
Note: the synchronous connector provides a full port of system metrics. The asynchronous connector by comparison cannot support bytes sent and bytes received because asyncpg doesn't provide a handle on the
underlying socket. If asyncpg accepts MagicStack/asyncpg#1313, we'll be able to
improve this situation.
Fixes #449.