-
Notifications
You must be signed in to change notification settings - Fork 509
perf: Optimize statCache expiration timestamp by using int64 instead of time.Time #4857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vedantdas-source
wants to merge
7
commits into
master
Choose a base branch
from
timestamp-optimize
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+114
−7
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
660df1c
perf: optimized timestamp memory consumption
vedantdas-source 4aff0fe
removed folder.go timestamp changes
vedantdas-source 875bb9b
Merge remote-tracking branch 'upstream/master' into timestamp-optimize
vedantdas-source d4c79fd
Merge remote-tracking branch 'upstream/master' into timestamp-optimize
vedantdas-source 0a984d9
Merge remote-tracking branch 'upstream/master' into timestamp-optimize
vedantdas-source 67ad8a8
changed to UnixNano() to avoid test failures caused by nanosecond inc…
vedantdas-source f2acd33
added utility function to avoid incorrect eviction
vedantdas-source File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| // Copyright 2026 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package metadata_test | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/googlecloudplatform/gcsfuse/v3/internal/cache/lru" | ||
| "github.com/googlecloudplatform/gcsfuse/v3/internal/cache/metadata" | ||
| "github.com/googlecloudplatform/gcsfuse/v3/internal/storage/gcs" | ||
| ) | ||
|
|
||
| func generateKeys(count int) []string { | ||
| keys := make([]string, count) | ||
| for i := 0; i < count; i++ { | ||
| keys[i] = fmt.Sprintf("object-%d", i) | ||
| } | ||
| return keys | ||
| } | ||
|
|
||
| func setupStatCache(capacity uint64) metadata.StatCache { | ||
| // 1000 items * approx 120 bytes each = ~120,000 bytes capacity | ||
| lruCache := lru.NewCache(capacity) | ||
| return metadata.NewStatCacheBucketView(lruCache, "") | ||
| } | ||
|
|
||
| func BenchmarkStatCache_Insert(b *testing.B) { | ||
| keys := generateKeys(10000) | ||
| cache := setupStatCache(uint64(len(keys) * 500)) | ||
| now := time.Now() | ||
|
|
||
| i := 0 | ||
| for b.Loop() { | ||
| key := keys[i%len(keys)] | ||
| m := &gcs.MinObject{Name: key} | ||
| cache.Insert(m, now) | ||
| i++ | ||
| } | ||
| } | ||
|
|
||
| func BenchmarkStatCache_AddNegativeEntry(b *testing.B) { | ||
| keys := generateKeys(10000) | ||
| cache := setupStatCache(uint64(len(keys) * 500)) | ||
| now := time.Now() | ||
|
|
||
| i := 0 | ||
| for b.Loop() { | ||
| key := keys[i%len(keys)] | ||
| cache.AddNegativeEntry(key, now) | ||
| i++ | ||
| } | ||
| } | ||
|
|
||
| func BenchmarkStatCache_LookUp(b *testing.B) { | ||
| keys := generateKeys(10000) | ||
| cache := setupStatCache(uint64(len(keys) * 500)) | ||
| now := time.Now() | ||
|
|
||
| // Pre-fill the cache with unexpired entries. | ||
| for _, key := range keys { | ||
| m := &gcs.MinObject{Name: key} | ||
| cache.Insert(m, now.Add(time.Hour)) | ||
| } | ||
|
|
||
| i := 0 | ||
| for b.Loop() { | ||
| key := keys[i%len(keys)] | ||
| _, _ = cache.LookUp(key, now) | ||
| i++ | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.