feat(storage): Override storage class in writers to RAPID when rapid writes enabled for Pirlo Buckets#4889
feat(storage): Override storage class in writers to RAPID when rapid writes enabled for Pirlo Buckets#4889vipnydav wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces logic to override the storage class to "RAPID" when rapid writes are enabled across various object creation methods (CreateObject, CreateObjectChunkWriter, and CreateAppendableObjectWriter), along with corresponding unit tests. The review feedback suggests avoiding direct mutation of the caller's request structs by using shallow copies instead, removing a redundant storage class override in CreateAppendableObjectWriter where it has no effect, and updating the unit tests to assert on the returned object attributes rather than the input request.
adfc500 to
f9d7314
Compare
f9d7314 to
40d086e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4889 +/- ##
==========================================
- Coverage 83.86% 83.84% -0.03%
==========================================
Files 173 173
Lines 21068 21090 +22
==========================================
+ Hits 17669 17683 +14
- Misses 2741 2745 +4
- Partials 658 662 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
This PR updates the bucket handle to explicitly set the storage class to
RAPIDwhen creating objects (viaCreateObject,CreateObjectChunkWriter, andCreateAppendableObjectWriter) if rapid writes are enabled for the Pirlo bucket. By default, the storage class is left empty to use the bucket's default, but when rapid writes are enabled (PirloStateRapidWritesEnabled), the intention to write to theRAPIDclass is now explicitly honored.Link to the issue in case of a bug fix.
b/534575467
Testing details
Any backward incompatible change? If so, please explain.
No.